Bug 9968: Fix wrong index for Standard number in advanced and label search
authorKatrin Fischer <katrin.fischer.83@web.de>
Wed, 16 May 2018 01:05:07 +0000 (01:05 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 9 Oct 2018 11:04:24 +0000 (11:04 +0000)
'Standard number' indicates that you can search ISBN, ISSN and other
standard numbers, but we are using the wrong index and only get a
very limited search for biblionumber instead.

This patch changes the index from sn to ident.

To test:
- Check both staff and OPAC advanced search:
  - Search for Standard number = ISBN
  - Search for Standard number = ISSN
  Both should work.
  Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences
- Check the label creator
  - Add a new batch
  - Use 'add items' option and search for Standard number

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc
koha-tmpl/intranet-tmpl/prog/en/modules/labels/search.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt

index 95d3684..1aff1a4 100644 (file)
@@ -23,9 +23,9 @@
     <option value="bc">Barcode</option>
     <option value="location">Shelving location</option>
     [% IF ( Koha.Preference('IntranetNumbersPreferPhrase') ) %]
-    <option value="sn,phr">Standard number</option>
+    <option value="ident,phr">Standard number</option>
     [% ELSE %]
-    <option value="sn">Standard number</option>
+    <option value="ident">Standard number</option>
     [% END %]
     <option value="nb">&nbsp;&nbsp;&nbsp;&nbsp; ISBN</option>
     <option value="ns">&nbsp;&nbsp;&nbsp;&nbsp; ISSN</option>
index 4e7e25f..039b63c 100644 (file)
@@ -30,7 +30,7 @@ to add to Batch [% batch_id | html %]
 [% IF idx == 'yr'  %]<option value="yr" selected="selected">Publication date</option>
 [% ELSE %]<option value="yr">Publication date</option>[% END %]
 
-[% IF idx == 'sn' %]<option value="sn" selected="selected">Standard number</option>
+[% IF idx == 'sn' %]<option value="ident" selected="selected">Standard number</option>
 [% ELSE %]<option value="sn">Standard number</option>[% END %]
 
 [% IF idx == 'nb' %]<option value="nb" selected="selected">ISBN</option>
index 427f737..8cbc5a9 100644 (file)
@@ -82,9 +82,9 @@
                                         <option value="pl,wrdl">Publisher location</option>
                                         [% IF ( expanded_options ) %]
                                             [% IF ( Koha.Preference('OPACNumbersPreferPhrase') ) %]
-                                                <option value="sn,phr">Standard number</option>
+                                                <option value="ident,phr">Standard number</option>
                                             [% ELSE %]
-                                                <option value="sn">Standard number</option>
+                                                <option value="ident">Standard number</option>
                                             [% END %]
                                             <option value="nb">&nbsp;&nbsp;&nbsp;&nbsp; ISBN</option>
                                             <option value="ns">&nbsp;&nbsp;&nbsp;&nbsp; ISSN</option>