Bug 17587: Remove itemtype-related IsItemIssued.t warnings

This patch makes t/db_dependent/Circulation/IsItemIssued.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Circulation/IsItemIssued.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Circulation/IsItemIssued.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/t/db_dependent/Circulation/IsItemIssued.t b/t/db_dependent/Circulation/IsItemIssued.t
index 2e1817e..67c9c74 100644 (file)
--- a/t/db_dependent/Circulation/IsItemIssued.t
+++ b/t/db_dependent/Circulation/IsItemIssued.t
@@ -35,9 +35,8 @@ my $schema = Koha::Database->schema;
 $schema->storage->txn_begin;
 my $builder = t::lib::TestBuilder->new;
 
-my $library = $builder->build({
-    source => 'Branch',
-});
+my $library = $builder->build({ source => 'Branch' });
+my $itemtype = $builder->build({ source => 'Itemtype' })->{itemtype};
 
 my $module = new Test::MockModule('C4::Context');
 $module->mock('userenv', sub {
@@ -53,12 +52,19 @@ my $borrowernumber = AddMember(
     branchcode => $library->{branchcode},
 );
 
-
 my $borrower = GetMember( borrowernumber => $borrowernumber );
 my $record = MARC::Record->new();
 my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, '' );
 
-my ( undef, undef, $itemnumber ) = AddItem( { homebranch => $library->{branchcode}, holdingbranch => $library->{branchcode}, barcode => 'i_dont_exist' }, $biblionumber );
+my ( undef, undef, $itemnumber ) = AddItem(
+    {   homebranch    => $library->{branchcode},
+        holdingbranch => $library->{branchcode},
+        barcode       => 'i_dont_exist',
+        itype         => $itemtype
+    },
+    $biblionumber
+);
+
 my $item = GetItem( $itemnumber );
 
 is ( IsItemIssued( $item->{itemnumber} ), 0, "item is not on loan at first" );