ARM: dts: omap: fix OF graph in omap3-devkit8000
authorRob Herring <robh@kernel.org>
Tue, 8 May 2018 13:59:29 +0000 (08:59 -0500)
committerTony Lindgren <tony@atomide.com>
Tue, 15 May 2018 18:09:13 +0000 (11:09 -0700)
omap3-devkit8000-common.dtsi defines a graph connection for DVI, but
then omap3-devkit8000-lcd-common.dtsi overrides that with a graph
connection for the LCD as the same output signals are used. This
leaves an incomplete graph as the TFP410 output has only half a
connection. The result is the following warning:

arch/arm/boot/dts/omap3-devkit8000-lcd70.dtb: Warning (graph_endpoint):
/encoder0/ports/port@0/endpoint: graph connection to node
'/ocp@68000000/dss@48050000/port/endpoint' is not bidirectional

Fix this by defining multiple endpoints which is the correct way to show
a 1 to many connection.

Cc: "BenoƮt Cousson" <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/boot/dts/omap3-devkit8000-common.dtsi
arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi

index 0c0bb1b..746a658 100644 (file)
        vdda_dac-supply = <&vdac>;
 
        port {
-               dpi_dvi_out: endpoint {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               dpi_dvi_out: endpoint@0 {
+                       reg = <0>;
                        remote-endpoint = <&tfp410_in>;
                        data-lines = <24>;
                };
+
+               endpoint@1 {
+                       reg = <1>;
+               };
        };
 };
 
index 2d64bcf..1093387 100644 (file)
 
 &dss {
        port {
-               dpi_lcd_out: endpoint {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               dpi_lcd_out: endpoint@1 {
+                       reg = <1>;
                        remote-endpoint = <&lcd_in>;
                        data-lines = <24>;
                };