Added some FIXME comments.

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index 093d8f8..b5f42c8 100755 (executable)
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -1,8 +1,4 @@
-package C4::Reserves; #asummes C4/Reserves
-
-#requires DBI.pm to be installed
-#uses DBD:Pg
-
+package C4::Reserves;
 
 # Copyright 2000-2002 Katipo Communications
 #
@@ -21,6 +17,8 @@ package C4::Reserves; #asummes C4/Reserves
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+# FIXME - I suspect that this module is obsolete.
+
 use strict;
 require Exporter;
 use DBI;
@@ -75,6 +73,8 @@ my $priv_func = sub {
                                                    
 # make all your functions, whether exported or not;
 
+# FIXME - This doesn't appear to ever be used, except in modules that
+# appear to be obsolete.
 sub EnterReserves{
   my ($env)=@_;  
   my $titlepanel = titlepanel($env,"Reserves","Enter Selection");
@@ -189,6 +189,8 @@ sub EnterReserves{
   return ($donext);  
 }
 
+# FIXME - A functionally identical version of this function appears in
+# C4::Reserves2. Pick one and stick with it.
 sub CalcReserveFee {
   my ($env,$borrnum,$biblionumber,$constraint,$bibitems) = @_;
   #check for issues;
@@ -261,6 +263,8 @@ sub CalcReserveFee {
   return $fee;
 } # end CalcReserveFee
 
+# FIXME - A somewhat different version of this function appears in
+# C4::Reserves2. Pick one and stick with it.
 sub CreateReserve {
   my ($env,$branch,$borrnum,$biblionumber,$constraint,$bibitems,$fee) = @_;
   my $dbh = C4::Context->dbh;

diff --git a/C4/Reserves2.pm b/C4/Reserves2.pm
index 7dcdd5e..ad0c401 100755 (executable)
--- a/C4/Reserves2.pm
+++ b/C4/Reserves2.pm
@@ -1,5 +1,4 @@
-package C4::Reserves2; #assumes C4/Reserves2
-
+package C4::Reserves2;
 
 # Copyright 2000-2002 Katipo Communications
 #
@@ -360,6 +359,8 @@ sub Findgroupreserve {
   return($i,@results);
 }
 
+# FIXME - A somewhat different version of this function appears in
+# C4::Reserves. Pick one and stick with it.
 sub CreateReserve {                                                           
   my
 ($env,$branch,$borrnum,$biblionumber,$constraint,$bibitems,$priority,$notes,$title)= @_;   
@@ -410,6 +411,8 @@ sub CreateReserve {
   return();   
 }             
 
+# FIXME - A functionally identical version of this function appears in
+# C4::Reserves. Pick one and stick with it.
 sub CalcReserveFee {
   my ($env,$borrnum,$biblionumber,$constraint,$bibitems) = @_;        
   #check for issues;