Bug 16534: Block AddIssue from issuing if the return is not possible

To make sure the return can be done, AddIssue must not trust callers (they
should have done their job, but we are not sure) and check that the issue can
be returned before issuing to the patron.

There is no test plan here, this should not be possible from the Koha
interface.
However, looking at the code, it may be possible using SIP.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index cd3ac70..13caa3f 100644 (file)
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -1386,6 +1386,8 @@ sub AddIssue {
                        if ( $actualissue->{borrowernumber}) {
                                # This book is currently on loan, but not to the person
                                # who wants to borrow it now. mark it returned before issuing to the new borrower
+                my ( $allowed, $message ) = CanBookBeReturned( $item, C4::Context->userenv->{branch} );
+                return unless $allowed;
                                AddReturn(
                                        $item->{'barcode'},
                                        C4::Context->userenv->{'branch'}