Bug 13813: [QA Follow-up] Fix some tabs for qa tools

FAIL   C4/Barcodes/annual.pm
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 86)
                forbidden pattern: tab char (line 51)

FAIL   C4/Barcodes/hbyymmincr.pm
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 108)
                forbidden pattern: tab char (line 78)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>

diff --git a/C4/Barcodes/annual.pm b/C4/Barcodes/annual.pm
index eb1b1e1..c2e8d0b 100644 (file)
--- a/C4/Barcodes/annual.pm
+++ b/C4/Barcodes/annual.pm
@@ -48,7 +48,7 @@ sub db_max ($;$) {
         $iso = output_pref({ dt => dt_from_string( $input, 'iso' ), dateformat => 'iso', dateonly => 1 }); # try to set the date w/ 2nd arg
                unless ($iso) {
                        warn "Failed to create 'iso' Dates object with input '$input'.  Reverting to today's date.";
-            $iso = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 });  # failover back to today
+            $iso = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }); # failover back to today
                }
        } else {
         $iso = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 });
@@ -83,7 +83,7 @@ sub width ($;$) {
 sub process_head($$;$$) {      # (self,head,whole,specific)
        my ($self,$head,$whole,$specific) = @_;
        $specific and return $head;     # if this is built off an existing barcode, just return the head unchanged.
-    return substr(output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), 0, 4 ) . '-';     # else get new YYYY-
+    return substr(output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }), 0, 4 ) . '-'; # else get new YYYY-
 }
 
 sub new_object {

diff --git a/C4/Barcodes/hbyymmincr.pm b/C4/Barcodes/hbyymmincr.pm
index 6845284..b60038e 100644 (file)
--- a/C4/Barcodes/hbyymmincr.pm
+++ b/C4/Barcodes/hbyymmincr.pm
@@ -75,7 +75,7 @@ sub db_max {
 sub initial {
        my $self = shift;
        # FIXME: populated branch?
-    my $iso = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 });       # like "2008-07-02"
+    my $iso = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }); # like "2008-07-02"
        return $self->branch . substr($iso,2,2) . substr($iso,5,2) . sprintf('%' . "$width.$width" . 'd',1);
 }
 
@@ -105,7 +105,7 @@ sub process_head {  # (self,head,whole,specific)
        my ($self,$head,$whole,$specific) = @_;
        $specific and return $head;     # if this is built off an existing barcode, just return the head unchanged.
        $head =~ s/\d{4}$//;            # else strip the old yymm
-    my $iso = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 });       # like "2008-07-02"
+    my $iso = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }); # like "2008-07-02"
        return $head . substr($iso,2,2) . substr($iso,5,2);
 }