Bug 18434 - Followup - same changes for sort and facet fields
authorNick Clemens <nick@bywatersolutions.com>
Fri, 16 Jun 2017 14:01:12 +0000 (10:01 -0400)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 6 Jul 2017 17:29:02 +0000 (14:29 -0300)
To test:
1 - Index some stuff with multiple fields defined for sorting
  i.e. Authorites - make heading sortable - default is 110a and 111a for
  heading - a record with 111a empty will make the sort field empty
2 - view the record:
curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true
3 - Note the blank field
4 - Apply patch
5 - Reindex
6 - Fields should be correctly populated

Unit tests to follow (once I have the originals working for all)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/SearchEngine/Elasticsearch.pm

index b079dca..43bb0a8 100644 (file)
@@ -328,7 +328,7 @@ sub get_fixer_rules {
             $options = '-split => 1' unless $marc_field =~ m|_/| || $type eq 'sum';
             push @rules, "marc_map('$marc_field','${name}.\$append', $options)";
             if ($facet) {
-                push @rules, "marc_map('$marc_field','${name}__facet', $options)";
+                push @rules, "marc_map('$marc_field','${name}__facet.\$append', $options)";
             }
             if ($suggestible) {
                 push @rules,
@@ -351,7 +351,7 @@ sub get_fixer_rules {
             # to do the default thing, which is make it sortable.
             if ($self->sort_fields()->{$name}) {
                 if ($sort || !defined $sort) {
-                    push @rules, "marc_map('$marc_field','${name}__sort', $options)";
+                    push @rules, "marc_map('$marc_field','${name}__sort.\$append', $options)";
                 }
             }
         }