Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0
authorLari Taskula <lari.taskula@jns.fi>
Wed, 2 Nov 2016 13:28:30 +0000 (15:28 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 4 Nov 2016 11:13:04 +0000 (11:13 +0000)
To test:
1. Set patron category "S" with enrolmentfee 1
2. perl t/db_dependent/Reserves.t
3. Observe following errors:

not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
ok 61 - Bug 14968 - Keep found column from reserve
not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge configured
ok 63 - Bug 14464 - 2nd reserve correctly created
not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge desired
ok 65 - Bug 14464 - 1st reserve correctly created
not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge desired and configured

4. Apply patch
5. perl t/db_dependent/Reserves.t
6. Observe test pass

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/Reserves.t

index 442c180..e19baa2 100755 (executable)
@@ -101,6 +101,7 @@ my %data = (
     categorycode => 'S',
     branchcode => 'CPL',
 );
+Koha::Patron::Categories->find('S')->set({ enrolmentfee => 0})->store;
 my $borrowernumber = AddMember(%data);
 my $borrower = GetMember( borrowernumber => $borrowernumber );
 my $biblionumber   = $bibnum;