Bug 3317: Author displaying inconsistently or not at all. Revision to previous patch.

Revision to previous patch for bug 3317.  Removes the EXPR command from opac-basket.tmpl, which was polluting the apache logs.

NTS: Don't use EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>

diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tmpl
index 100bf83..8427d45 100644 (file)
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tmpl
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tmpl
@@ -80,7 +80,6 @@
             <td><!-- TMPL_VAR NAME="isbn" --></td>
         </tr>
         <!-- /TMPL_IF -->
-        
         <!-- TMPL_IF name="MARCAUTHORS" -->
         <tr>
             <th scope="row">Authors</th>

diff --git a/opac/opac-basket.pl b/opac/opac-basket.pl
index b36e8c1..a50bdd5 100755 (executable)
--- a/opac/opac-basket.pl
+++ b/opac/opac-basket.pl
@@ -62,6 +62,11 @@ foreach my $biblionumber ( @bibs ) {
     my $marcseriesarray  = GetMarcSeries  ($record,$marcflavour);
     my $marcurlsarray    = GetMarcUrls    ($record,$marcflavour);
     my @items            = &GetItemsInfo( $biblionumber, 'opac' );
+
+    my $hasauthors = 0;
+    if($dat->{'author'} || @$marcauthorsarray) {
+      $hasauthors = 1;
+    }
        
     my $shelflocations =GetKohaAuthorisedValues('items.location',$dat->{'frameworkcode'});
     my $collections =  GetKohaAuthorisedValues('items.ccode',$dat->{'frameworkcode'} );
@@ -90,6 +95,7 @@ foreach my $biblionumber ( @bibs ) {
     $dat->{MARCAUTHORS}    = $marcauthorsarray;
     $dat->{MARCSERIES}  = $marcseriesarray;
     $dat->{MARCURLS}    = $marcurlsarray;
+    $dat->{HASAUTHORS}  = $hasauthors;
 
     if ( C4::Context->preference("BiblioDefaultView") eq "normal" ) {
         $dat->{dest} = "opac-detail.pl";