Bug 15607: batch patron mod - do not update dates if not given
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 20 Jan 2016 08:45:48 +0000 (08:45 +0000)
committerJesse Weaver <jweaver@bywatersolutions.com>
Thu, 21 Jan 2016 00:16:42 +0000 (17:16 -0700)
Bug 15332 fixed a bug but introduced a bigger one. Even if dateenrolled and
dateexpiry are not modified, they will be updated to today.
Indeed, dt_from_string returns today without parameters.

Test plan:
- Set dateenrolled and expirydate for a patron
- Using the batch patron mod tool, update any field but dateenrolled and
expirydate.
=> Without this patch, the 2 date fields should be set to today
=> With this patch applied, the 2 date fields should not have been
modified.

Signed-off-by: Karam Qubsi <karamqubsi@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
tools/modborrowers.pl

index f88581f..95d26de 100755 (executable)
@@ -266,7 +266,7 @@ if ( $op eq 'do' ) {
     }
 
     for my $field ( qw( dateenrolled dateexpiry ) ) {
-        $infos->{$field} = dt_from_string($infos->{$field});
+        $infos->{$field} = dt_from_string($infos->{$field}) if $infos->{$field};
     }
 
     my @attributes = $input->param('patron_attributes');