Bug 17607: Fix patron definition in Swagger
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 10 Nov 2016 13:21:52 +0000 (10:21 -0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Mon, 14 Nov 2016 11:25:25 +0000 (11:25 +0000)
This patch makes the patron swagger definition match the DB schema.
To test:
- Run:
  $ prove t/db_dependent/api/v1/swagger/definitions.t
=> FAIL: 'lastseen' field is not declared in the swagger definition
- Apply the patch
- Run:
  $ prove t/db_dependent/api/v1/swagger/definitions.t
=> SUCCESS: Tests pass!
- Sigh off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
All tests pass successfuly

Signed-off-by: Lari Taskula <lari.taskula@jns.fi>
Fixed a typo: seed -> seen

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
api/v1/swagger/definitions/patron.json

index a021502..84f298a 100644 (file)
     "updated_on": {
       "type": "string",
       "description": "time of last change could be useful for synchronization with external systems (among others)"
+    },
+    "lastseen": {
+      "type": ["string", "null"],
+      "description": "last time a patron has been seen (connected at the OPAC or staff interface)"
     }
   }
 }