Bug 18179: Update existing calls

This patch updates the existing occurrences of ->find called in a list
context.
There are certainly others that are not easy to catch with git grep.
Test plan:
Confirm that the 4 modified scripts still works as expected.

We need this one ASAP in master to make sure we will not get other
side-effects of this kind and to catch possible uncaught occurrences
before the release.

Tested scripts changed by this patch, they work as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/members/memberentry.pl b/members/memberentry.pl
index 768b163..c13faa5 100755 (executable)
--- a/members/memberentry.pl
+++ b/members/memberentry.pl
@@ -753,7 +753,7 @@ $template->param( csrf_token =>
 
 # HouseboundModule data
 $template->param(
-    housebound_role  => Koha::Patron::HouseboundRoles->find($borrowernumber),
+    housebound_role  => scalar Koha::Patron::HouseboundRoles->find($borrowernumber),
 );
 
 if(defined($data{'flags'})){

diff --git a/members/moremember.pl b/members/moremember.pl
index 4f88862..9d76d76 100755 (executable)
--- a/members/moremember.pl
+++ b/members/moremember.pl
@@ -346,7 +346,7 @@ $template->param(
     is_child        => ($category_type eq 'C'),
     samebranch      => $samebranch,
     quickslip       => $quickslip,
-    housebound_role => $patron->housebound_role,
+    housebound_role => scalar $patron->housebound_role,
     privacy_guarantor_checkouts => $data->{'privacy_guarantor_checkouts'},
     AutoResumeSuspendedHolds => C4::Context->preference('AutoResumeSuspendedHolds'),
     SuspendHoldsIntranet => C4::Context->preference('SuspendHoldsIntranet'),

diff --git a/members/pay.pl b/members/pay.pl
index 2e25eef..3400ee0 100755 (executable)
--- a/members/pay.pl
+++ b/members/pay.pl
@@ -94,7 +94,7 @@ if ($writeoff_all) {
     Koha::Account->new( { patron_id => $borrowernumber } )->pay(
         {
             amount     => $amount,
-            lines      => [Koha::Account::Lines->find($accountlines_id)],
+            lines      => [ scalar Koha::Account::Lines->find($accountlines_id) ],
             type       => 'writeoff',
             note       => $payment_note,
             library_id => $branch,
@@ -208,7 +208,7 @@ sub writeoff_all {
             Koha::Account->new( { patron_id => $borrowernumber } )->pay(
                 {
                     amount => $amount,
-                    lines  => [ Koha::Account::Lines->find($accountlines_id) ],
+                    lines  => [ scalar Koha::Account::Lines->find($accountlines_id) ],
                     type   => 'writeoff',
                     note   => $payment_note,
                     library_id => $branch,

diff --git a/opac/opac-user.pl b/opac/opac-user.pl
index 3dc39bf..adba791 100755 (executable)
--- a/opac/opac-user.pl
+++ b/opac/opac-user.pl
@@ -337,7 +337,7 @@ if (   C4::Context->preference('AllowPatronToSetCheckoutsVisibilityForGuarantor'
 }
 
 $template->param(
-    borrower                 => Koha::Patrons->find($borrowernumber),
+    borrower                 => scalar Koha::Patrons->find($borrowernumber),
     patron_messages          => $patron_messages,
     opacnote                 => $borr->{opacnote},
     patronupdate             => $patronupdate,