BUG8446, QA Followup: Minor Code Tidies

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/C4/Auth.pm b/C4/Auth.pm
index c0bd618..684faae 100644 (file)
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -58,12 +58,12 @@ BEGIN {
     $shib        = C4::Context->config('useshibboleth') || 0;
     $caslogout   = C4::Context->preference('casLogout');
     require C4::Auth_with_cas;             # no import
-    require C4::Auth_with_shibboleth;
     if ($ldap) {
     require C4::Auth_with_ldap;
     import C4::Auth_with_ldap qw(checkpw_ldap);
     }
     if ($shib) {
+        require C4::Auth_with_shibboleth;
         import C4::Auth_with_shibboleth
           qw(shib_ok checkpw_shib logout_shib login_shib_url get_login_shib);
 

diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm
index ec954cd..d2a4cdf 100644 (file)
--- a/C4/Auth_with_shibboleth.pm
+++ b/C4/Auth_with_shibboleth.pm
@@ -17,8 +17,7 @@ package C4::Auth_with_shibboleth;
 # You should have received a copy of the GNU General Public License
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use strict;
-use warnings;
+use Modern::Perl;
 
 use C4::Debug;
 use C4::Context;

diff --git a/t/Auth_with_shibboleth.t b/t/Auth_with_shibboleth.t
index f400989..bd627e2 100644 (file)
--- a/t/Auth_with_shibboleth.t
+++ b/t/Auth_with_shibboleth.t
@@ -1,6 +1,5 @@
 #!/usr/bin/perl
 #
-# This Koha test module is a stub!
 # Add more tests here!!!
 
 use Modern::Perl;