ASoC: rsnd: tidyup rsnd_parse_connect_ssiu_compatible()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Wed, 21 Nov 2018 01:58:30 +0000 (01:58 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 21 Nov 2018 13:27:21 +0000 (13:27 +0000)
rsnd_parse_connect_ssiu_compatible() is doing
 - using rsnd_ssiu_id(), but we use it via rsnd_mod_id()
 - we can break loop if rsnd_dai_connect() was called
This patch fixup these.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/ssiu.c

index 650b14e..04b1a48 100644 (file)
@@ -382,9 +382,11 @@ static void rsnd_parse_connect_ssiu_compatible(struct rsnd_priv *priv,
        for_each_rsnd_ssiu(ssiu, priv, i) {
                mod = rsnd_mod_get(ssiu);
 
-               if ((rsnd_mod_id(ssi_mod) == rsnd_ssiu_id(mod)) &&
-                   (rsnd_mod_id_sub(mod) == 0))
+               if ((rsnd_mod_id(ssi_mod) == rsnd_mod_id(mod)) &&
+                   (rsnd_mod_id_sub(mod) == 0)) {
                        rsnd_dai_connect(mod, io, mod->type);
+                       return;
+               }
        }
 }