Bug 17737: Remove C4::Reserves::GetReservesFromItemnumber
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 7 Dec 2016 13:04:17 +0000 (14:04 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Thu, 13 Apr 2017 12:49:12 +0000 (08:49 -0400)
At this point, there should not be any occurrences of
GetReservesFromItemnumber anymore.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Reserves.pm

index 1598eb6..3192d50 100644 (file)
@@ -104,7 +104,6 @@ BEGIN {
         &AddReserve
 
         &GetReserve
-        &GetReservesFromItemnumber
         &GetReservesFromBorrowernumber
         &GetReservesForBranch
         &GetReservesToBranch
@@ -279,46 +278,6 @@ sub GetReserve {
     return $sth->fetchrow_hashref();
 }
 
-=head2 GetReservesFromItemnumber
-
- ( $reservedate, $borrowernumber, $branchcode, $reserve_id, $waitingdate ) = GetReservesFromItemnumber($itemnumber);
-
-Get the first reserve for a specific item number (based on priority). Returns the abovementioned values for that reserve.
-
-The routine does not look at future reserves (read: item level holds), but DOES include future waits (a confirmed future hold).
-
-=cut
-
-sub GetReservesFromItemnumber {
-    my ($itemnumber) = @_;
-
-    my $schema = Koha::Database->new()->schema();
-
-    my $r = $schema->resultset('Reserve')->search(
-        {
-            itemnumber => $itemnumber,
-            suspend    => 0,
-            -or        => [
-                reservedate => \'<= CAST( NOW() AS DATE )',
-                waitingdate => { '!=', undef }
-            ]
-        },
-        {
-            order_by => 'priority',
-        }
-    )->first();
-
-    return unless $r;
-
-    return (
-        $r->reservedate(),
-        $r->get_column('borrowernumber'),
-        $r->get_column('branchcode'),
-        $r->reserve_id(),
-        $r->waitingdate(),
-    );
-}
-
 =head2 GetReservesFromBorrowernumber
 
     $borrowerreserv = GetReservesFromBorrowernumber($borrowernumber,$tatus);