Bug 16325: Do not return all suggestions if search for STATUS=''

This is a quick and dirty way to fix a bad bug in a messy area.
The "unknown status" tab in the suggestions table display all the
suggestions. It should only display suggestions with a STATUS=''

Test plan:
- Create some suggestions
- Go to Home > Acquisitions > Suggestions management
- Edit some suggestions and give them different status,
e.g. accepted, rejected, pending.
- Verify that they appear in the tabs as appropriate
- Edit one suggestion, set "Mark selected as" to --Choose a status--
=> Without this patch: New tab "Status unknown" containing all
suggestions
=> With this patch: tab contains only suggestions with "Unknown status"

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>

diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm
index 63e10ed..8e76cea 100644 (file)
--- a/C4/Suggestions.pm
+++ b/C4/Suggestions.pm
@@ -160,7 +160,10 @@ sub SearchSuggestion {
         if ( exists $suggestion->{$field}
                 and defined $suggestion->{$field}
                 and $suggestion->{$field} ne '__ANY__'
-                and $suggestion->{$field} ne q||
+                and (
+                    $suggestion->{$field} ne q||
+                        or $field eq 'STATUS'
+                )
         ) {
             if ( $suggestion->{$field} eq '__NONE__' ) {
                 push @query, qq{ AND (suggestions.$field = '' OR suggestions.$field IS NULL) };