Bug 13099 - "Item hasn't been transferred yet" shows pickup branch rather than holdin...

The "Item hasn't been transferred yet" message on circulation.pl and
moremember.pl in the holds table shows the pickup branch rather than
holding branch.

Test Plan:
1) Place an item on hold for a patron
2) Check the item in to set the hold to waiting
3) Place an item level hold for another patron,
   make the pickup location be a different library
4) Load the holds tab on the patron details page for the second patron
5) Note it says "Item hasn't been transferred yet from <Pickup Library>"
6) Apply this patch
7) Repeat step 4
8) Note the library listed is now the holding library

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described and passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/svc/holds b/svc/holds
index 3ff704f..43bcf2a 100755 (executable)
--- a/svc/holds
+++ b/svc/holds
@@ -128,7 +128,7 @@ while ( my $h = $holds_rs->next() ) {
             $h->branchcode()->branchcode() )
         {
             $hold->{not_transferred}    = 1;
-            $hold->{not_transferred_by} = $h->branchcode()->branchname();
+            $hold->{not_transferred_by} = $h->item()->holdingbranch()->branchname();
         }
     }