Bug 15415: Warn when creating a new print profile

As per Jonathan's comment in Comment 3, I've put that line of code in an
if statement that will only call the get_attr method if we are editing
an existing profile (therefore the profile id will exist).

To test:
1) Go to Tools -> Patron Card Creator -> New printer profile
2) Notice warn
3) Apply patch
4) Refresh page
5) Confirm warn is gone and page still works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/patroncards/edit-profile.pl b/patroncards/edit-profile.pl
index 55e903c..0dc312f 100755 (executable)
--- a/patroncards/edit-profile.pl
+++ b/patroncards/edit-profile.pl
@@ -88,7 +88,9 @@ foreach my $unit (@$units) {
     }
 }
 
-$template->param(profile_id => $profile->get_attr('profile_id')) if $profile->get_attr('profile_id') > 0;
+if ($profile_id) { # if new layout, there will be no profile id, so shouldn't look for it
+    $template->param(profile_id => $profile->get_attr('profile_id')) if $profile->get_attr('profile_id') > 0;
+}
 
 $template->param(
     label_template      => $label_template[0]->{'template_code'} || '',