Bug 14257: Follow-up - Add documentation, fix typo, fix test

- t/db_dependent/ILSDI_Services.t was failing for me as I had
  issues in my database, fixed with another delete line
- QA tools found a typo - comparision
- Added documentation of the new parameter to the ilsdi.pl page

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
index e6544cc..993af71 100644 (file)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
@@ -514,6 +514,8 @@
                                     <dd>whether or not to return hold request information in the response</dd>
                                     <dt><strong>show_loans</strong> (Optional, default 0)</dt>
                                     <dd>whether or not to return loan information in the response</dd>
+                                    <dt><strong>show_attributes</strong> (Optional, default 0)</dt>
+                                    <dd>whether or not to return extended patron attributes information in the response</dd>
                                 </dl>
                                 <h4>Example call</h4>
                                 <a href="ilsdi.pl?service=GetPatronInfo&amp;patron_id=1&amp;show_contact=0&amp;show_loans=1">

diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t
index 73313bf..ee012e2 100644 (file)
--- a/t/db_dependent/ILSDI_Services.t
+++ b/t/db_dependent/ILSDI_Services.t
@@ -100,6 +100,7 @@ $dbh->{RaiseError} = 0;
 my $schema = Koha::Database->schema;
 $schema->storage->txn_begin;
 
+$schema->resultset( 'Issue' )->delete_all;
 $schema->resultset( 'Borrower' )->delete_all;
 $schema->resultset( 'BorrowerAttribute' )->delete_all;
 $schema->resultset( 'BorrowerAttributeType' )->delete_all;
@@ -180,7 +181,7 @@ $schema->resultset( 'Branch' )->delete_all;
 
     my $reply = C4::ILSDI::Services::GetPatronInfo( $query );
 
-    # Build a structure for comparision:
+    # Build a structure for comparison:
     my $cmp = {
         category_code     => $attr_type->{'category_code'},
         class             => $attr_type->{'class'},
@@ -193,7 +194,7 @@ $schema->resultset( 'Branch' )->delete_all;
     };
 
     # Check results:
-    is_deeply( $reply->{'attributes'}, [ $cmp ] );
+    is_deeply( $reply->{'attributes'}, [ $cmp ], 'Test GetPatronInfo - show_attributes parameter' );
 }
 
 # Cleanup