Bug 15006 Correct indentation of EXPORTs in Sip.pm
authorColin Campbell <colin.campbell@ptfs-europe.com>
Wed, 6 Jul 2016 14:25:21 +0000 (15:25 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 15 Jul 2016 14:11:05 +0000 (14:11 +0000)
Removed tabs and used spaces consistently
Used 'use base' to remove unnecessary BEGIN sub and
explicit setting of ISA at application level

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/SIP/Sip.pm

index 52eda1f..3f41226 100644 (file)
@@ -16,22 +16,18 @@ use IO::Handle;
 use C4::SIP::Sip::Constants qw(SIP_DATETIME FID_SCREEN_MSG);
 use C4::SIP::Sip::Checksum qw(checksum);
 
-use vars qw(@ISA @EXPORT_OK %EXPORT_TAGS);
-
-BEGIN {
-       @ISA = qw(Exporter);
-
-       @EXPORT_OK = qw(y_or_n timestamp add_field maybe_add add_count
-                   denied sipbool boolspace write_msg
-                   $error_detection $protocol_version $field_delimiter
-                   $last_response);
-
-       %EXPORT_TAGS = (
-                   all => [qw(y_or_n timestamp add_field maybe_add
-                              add_count denied sipbool boolspace write_msg
-                              $error_detection $protocol_version
-                              $field_delimiter $last_response)]);
-}
+use base qw(Exporter);
+
+our @EXPORT_OK = qw(y_or_n timestamp add_field maybe_add add_count
+    denied sipbool boolspace write_msg
+    $error_detection $protocol_version $field_delimiter
+    $last_response);
+
+our %EXPORT_TAGS = (
+    all => [qw(y_or_n timestamp add_field maybe_add
+        add_count denied sipbool boolspace write_msg
+        $error_detection $protocol_version
+        $field_delimiter $last_response)]);
 
 our $error_detection = 0;
 our $protocol_version = 1;