Bug 7841: add a direct regression test
authorGalen Charlton <gmc@esilibrary.com>
Mon, 19 May 2014 16:40:23 +0000 (16:40 +0000)
committerGalen Charlton <gmc@esilibrary.com>
Mon, 19 May 2014 16:40:23 +0000 (16:40 +0000)
This patch adds a direct regression test for verifying that
no warnings are generated when getTranslatedLanguages() is called
without a defined current language, as might happen during
installation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
t/db_dependent/Languages.t

index 474987f..ca4413e 100755 (executable)
@@ -6,9 +6,10 @@
 use strict;
 use warnings;
 
-use Test::More tests => 11;
+use Test::More tests => 13;
 use List::Util qw(first);
 use Data::Dumper;
+use Test::Warn;
 
 BEGIN {
     use_ok('C4::Languages');
@@ -40,12 +41,18 @@ C4::Context->set_preference('AdvancedSearchLanguages', 'ita|eng');
 $languages = C4::Languages::getLanguages('eng', 1);
 is(scalar(@$languages), 2, 'getLanguages() filtering using AdvancedSearchLanguages works');
 
-my $translatedlanguages1 = C4::Languages::getTranslatedLanguages('opac','prog',undef,'');
+my $translatedlanguages1;
+warnings_are { $translatedlanguages1 = C4::Languages::getTranslatedLanguages('opac','prog',undef,'') }
+             [],
+             'no warnings for calling getTranslatedLanguages';
 my @currentcheck1 = map { $_->{current} } @$translatedlanguages1;
 my $onlyzeros = first { $_ != 0 } @currentcheck1;
 ok(! $onlyzeros, "Everything was zeros.\n");
 
-my $translatedlanguages2 = C4::Languages::getTranslatedLanguages('opac','prog','en','');
+my $translatedlanguages2;
+warnings_are { $translatedlanguages2 = C4::Languages::getTranslatedLanguages('opac','prog','en','') }
+             [],
+             'no warnings for calling getTranslatedLanguages';
 my @currentcheck2 = map { $_->{current} } @$translatedlanguages2;
 $onlyzeros = first { $_ != 0 } @currentcheck2;
 ok($onlyzeros, "There is a $onlyzeros\n");