Bug 20763: Remove unecessary Koha::Patron fetch

If $borrowernumber is not set, there is no userenv.
So let's pick the library code set in the userenv instead of fetching
the Koha::Patron->branchcode from DB

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl
index c29278c..19493aa 100755 (executable)
--- a/opac/opac-suggestions.pl
+++ b/opac/opac-suggestions.pl
@@ -198,12 +198,7 @@ my $patron_reason_loop = GetAuthorisedValues("OPAC_SUG");
 if ( C4::Context->preference("AllowPurchaseSuggestionBranchChoice") ) {
     my $branchcode = $input->param('branchcode') || q{};
 
-    if ( !$branchcode && $borrowernumber ) {
-        my $patron = Koha::Patrons->find($borrowernumber);
-        $branchcode = $patron->branchcode;
-    }
-
-    if (   !$branchcode
+    if ( !$branchcode
         && C4::Context->userenv
         && C4::Context->userenv->{branch} )
     {