Bug 14202: Unexpected parameter for window.open in marc21_linking_section.pl
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 14 Jul 2015 19:57:10 +0000 (21:57 +0200)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 6 Nov 2015 18:11:19 +0000 (15:11 -0300)
The builder of this plugin includes a window.open call with the name
parameter: \"marc21_field_7\"+ event.data.id +\"\"
Note that this is not the name of the new window.
This trivial patch adjusts this unusual name by tag_editor like other
plugins.

Test plan:
Attach marc21_linking_section to 773$9.
Click on the Tag editor button.
If it opens, it still works :)
Note that the name of the popup is still:
    Koha > Cataloguing > plugin for links

Signed-off-by: Fredreic Demians <f.demians@tamil.fr>
  Plugin still working, with a valid pop-pup window id.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
cataloguing/value_builder/marc21_linking_section.pl

index 195dedb..13f3a64 100644 (file)
@@ -41,7 +41,7 @@ my $builder = sub {
   <script type='text/javascript'>
              function Click$function_name(event) {
                        defaultvalue=document.getElementById(event.data.id).value;
-                 window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&index=\" + event.data.id + \"&result=\"+defaultvalue,\"marc21_field_7\"+ event.data.id +\"\",'width=900,height=700,toolbar=false,scrollbars=yes');
+                 window.open(\"/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&index=\" + event.data.id + \"&result=\"+defaultvalue, 'tag_editor', 'width=900,height=700,toolbar=false,scrollbars=yes');
 
              }
       </script>
@@ -315,4 +315,4 @@ my $launcher = sub {
     output_html_with_http_headers $query, $cookie, $template->output;
 };
 
-return { builder => $builder, launcher => $launcher };
\ No newline at end of file
+return { builder => $builder, launcher => $launcher };