Remove generation of an unnecessary warning
authorColin Campbell <colin.campbell@ptfs-europe.com>
Wed, 19 May 2010 14:00:09 +0000 (15:00 +0100)
committerGalen Charlton <gmcharlt@gmail.com>
Mon, 24 May 2010 14:22:29 +0000 (10:22 -0400)
We've checked the return for definedness and
assigned an empty string to it ao we don't want
to make it undef again

This is a good argument that cascading if-elses expecially with
long unstructured elses are a bad idea

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
acqui/basket.pl

index 7c2456a..9381ae6 100755 (executable)
@@ -172,7 +172,7 @@ if ( $op eq 'delete_confirm' ) {
             basketgroupname => $basket->{'basketname'});
         
     }
-} elsif ($query->param('op') eq 'reopen') {
+} elsif ($op eq 'reopen') {
     my $basket;
     $basket->{basketno} = $query->param('basketno');
     $basket->{closedate} = undef;