Bug 13098: Sum at DBMS level

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/Koha/Account/Offsets.pm b/Koha/Account/Offsets.pm
index d788058..bcc5a64 100644 (file)
--- a/Koha/Account/Offsets.pm
+++ b/Koha/Account/Offsets.pm
@@ -18,7 +18,6 @@ package Koha::Account::Offsets;
 use Modern::Perl;
 
 use Carp;
-use List::Util qw(sum0);
 
 use Koha::Database;
 
@@ -41,11 +40,19 @@ Account offsets track the changes made to the balance of account lines
 =cut
 
 sub total {
-    my ( $self ) = @_;
-
-    my $total = sum0( $self->get_column('amount') );
-
-    return $total;
+    my ($self) = @_;
+
+    my $offsets = $self->search(
+        {},
+        {
+            select => [ { sum => 'amount' } ],
+            as     => ['total_amount'],
+        }
+    );
+
+    return $offsets->count
+      ? $offsets->next->get_column('total_amount') + 0
+      : 0;
 }
 
 =head2 Internal methods