Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads to mistakes
authorMarc Véron <veron@veron.ch>
Thu, 18 May 2017 18:02:33 +0000 (20:02 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 15 Jun 2017 18:56:00 +0000 (15:56 -0300)
The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
mistakes.

To test:
- Apply patch
- Enroll a patron to a club
- Enable public enrollment in OPAC
- Verify that the button to cancel enrollment in both OPAC and staff client
  reads 'Cancel enrollement' (instead of 'Cancel' without patch)
  (The button appears on the patron's detail pages in OPAC and staff client)

Amended for comment #4 / mv

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt

index af078b4..5862422 100644 (file)
@@ -22,7 +22,7 @@
                     [% IF CAN_user_clubs_enroll %]
                         <td>
                             <button class="btn btn-xs btn-default" onclick="cancelEnrollment( [% e.id %] )">
-                                <i class="fa fa-remove"></i> Cancel
+                                <i class="fa fa-remove"></i> Cancel enrollment
                             </button>
                         </td>
                     [% END %]
index 1c5580a..df0e297 100644 (file)
@@ -23,7 +23,7 @@
                     [% IF e.club.club_template.is_enrollable_from_opac %]
                         <td>
                             <button class="btn btn-xs btn-default" onclick="cancelEnrollment( [% e.id %] )">
-                                <i class="icon-remove"></i> Cancel
+                                <i class="icon-remove"></i> Cancel enrollment
                             </button>
                         </td>
                     [% END %]