Bug 8128 - can't seem to run new sql reports
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 18 May 2012 19:01:45 +0000 (15:01 -0400)
committerPaul Poulain <paul.poulain@biblibre.com>
Thu, 24 May 2012 13:48:37 +0000 (15:48 +0200)
Reports cannot be saved because saved_sql.cache_expiry cannot be null.
Fixed by setting default to 0 if a cache_expiry value is not
passed into the function.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes t xt

Verified original bug, patch resolves issue.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
C4/Reports/Guided.pm

index 8081b32..c82e995 100644 (file)
@@ -473,6 +473,7 @@ Returns id of the newly created report
 
 sub save_report {
     my ( $borrowernumber, $sql, $name, $type, $notes, $cache_expiry, $public ) = @_;
+    $cache_expiry ||= 0;
     my $dbh = C4::Context->dbh();
     $sql =~ s/(\s*\;\s*)$//; # removes trailing whitespace and /;/
     my $query =