Revert "Bug 22026: Removed 'use Modern::Perl;' from Koha::REST::classes"

This causes test failures in D8 and would require packaging our own perlcritic
Reverting until future date when consequences do not outweigh benefits

This reverts commit ecc94da6b258e423799e58558a5b02c8f2fcefec.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/Koha/REST/Plugin/Objects.pm b/Koha/REST/Plugin/Objects.pm
index 931c647..3653f91 100644 (file)
--- a/Koha/REST/Plugin/Objects.pm
+++ b/Koha/REST/Plugin/Objects.pm
@@ -15,6 +15,8 @@ package Koha::REST::Plugin::Objects;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Plugin';
 
 =head1 NAME

diff --git a/Koha/REST/Plugin/Pagination.pm b/Koha/REST/Plugin/Pagination.pm
index 47c7fc0..0256005 100644 (file)
--- a/Koha/REST/Plugin/Pagination.pm
+++ b/Koha/REST/Plugin/Pagination.pm
@@ -15,6 +15,8 @@ package Koha::REST::Plugin::Pagination;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Plugin';
 
 =head1 NAME

diff --git a/Koha/REST/Plugin/PluginRoutes.pm b/Koha/REST/Plugin/PluginRoutes.pm
index 17ccab3..f51c7bd 100644 (file)
--- a/Koha/REST/Plugin/PluginRoutes.pm
+++ b/Koha/REST/Plugin/PluginRoutes.pm
@@ -15,6 +15,8 @@ package Koha::REST::Plugin::PluginRoutes;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Plugin';
 
 use Koha::Exceptions::Plugin;

diff --git a/Koha/REST/Plugin/Query.pm b/Koha/REST/Plugin/Query.pm
index 21479f8..090f02f 100644 (file)
--- a/Koha/REST/Plugin/Query.pm
+++ b/Koha/REST/Plugin/Query.pm
@@ -15,6 +15,8 @@ package Koha::REST::Plugin::Query;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Plugin';
 
 use Koha::Exceptions;

diff --git a/Koha/REST/V1.pm b/Koha/REST/V1.pm
index df327e9..b1f4657 100644 (file)
--- a/Koha/REST/V1.pm
+++ b/Koha/REST/V1.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious';
 
 use C4::Context;

diff --git a/Koha/REST/V1/Acquisitions/Vendors.pm b/Koha/REST/V1/Acquisitions/Vendors.pm
index 79f401f..5f86ac8 100644 (file)
--- a/Koha/REST/V1/Acquisitions/Vendors.pm
+++ b/Koha/REST/V1/Acquisitions/Vendors.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1::Acquisitions::Vendors;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Controller';
 
 use Koha::Acquisition::Booksellers;

diff --git a/Koha/REST/V1/Auth.pm b/Koha/REST/V1/Auth.pm
index 0dbd9c8..92cafc2 100644 (file)
--- a/Koha/REST/V1/Auth.pm
+++ b/Koha/REST/V1/Auth.pm
@@ -17,6 +17,8 @@ package Koha::REST::V1::Auth;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Controller';
 
 use C4::Auth qw( check_cookie_auth checkpw_internal get_session haspermission );

diff --git a/Koha/REST/V1/Cities.pm b/Koha/REST/V1/Cities.pm
index 8bca97c..5a579b4 100644 (file)
--- a/Koha/REST/V1/Cities.pm
+++ b/Koha/REST/V1/Cities.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1::Cities;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Controller';
 
 use Koha::Cities;

diff --git a/Koha/REST/V1/Hold.pm b/Koha/REST/V1/Hold.pm
index bc25750..c3cb926 100644 (file)
--- a/Koha/REST/V1/Hold.pm
+++ b/Koha/REST/V1/Hold.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1::Hold;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Controller';
 
 use C4::Biblio;

diff --git a/Koha/REST/V1/Illrequests.pm b/Koha/REST/V1/Illrequests.pm
index 94ff8ce..2e428f7 100644 (file)
--- a/Koha/REST/V1/Illrequests.pm
+++ b/Koha/REST/V1/Illrequests.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1::Illrequests;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Controller';
 
 use Koha::Illrequests;

diff --git a/Koha/REST/V1/OAuth.pm b/Koha/REST/V1/OAuth.pm
index e7c8ec7..b75c892 100644 (file)
--- a/Koha/REST/V1/OAuth.pm
+++ b/Koha/REST/V1/OAuth.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1::OAuth;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Module::Load::Conditional;
 
 use C4::Context;

diff --git a/Koha/REST/V1/Patrons.pm b/Koha/REST/V1/Patrons.pm
index 5315596..5e8e398 100644 (file)
--- a/Koha/REST/V1/Patrons.pm
+++ b/Koha/REST/V1/Patrons.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1::Patrons;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Controller';
 
 use Koha::DateUtils;

diff --git a/Koha/REST/V1/Patrons/Account.pm b/Koha/REST/V1/Patrons/Account.pm
index 3fd3eef..deb4d3d 100644 (file)
--- a/Koha/REST/V1/Patrons/Account.pm
+++ b/Koha/REST/V1/Patrons/Account.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1::Patrons::Account;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Controller';
 
 use Koha::Patrons;

diff --git a/Koha/REST/V1/Stage.pm b/Koha/REST/V1/Stage.pm
index f439e97..485384a 100644 (file)
--- a/Koha/REST/V1/Stage.pm
+++ b/Koha/REST/V1/Stage.pm
@@ -15,6 +15,8 @@ package Koha::REST::V1::Stage;
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+use Modern::Perl;
+
 use Mojo::Base 'Mojolicious::Controller';
 
 use Koha::StockRotationRotas;