Bug 8917 : Shifting db dependent code to a module

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

diff --git a/Koha/Linktracker.pm b/Koha/Linktracker.pm
new file mode 100644 (file)
index 0000000..52e68be
--- /dev/null
+++ b/Koha/Linktracker.pm
@@ -0,0 +1,69 @@
+package Koha::Linktracker;
+
+# Copyright 2013 chris@bigballofwax.co.nz
+#
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it under the
+# terms of the GNU General Public License as published by the Free Software
+# Foundation; either version 3 of the License, or (at your option) any later
+# version.
+#
+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+=head1 NAME
+
+Koha::Linktracker
+
+=head1 SYNOPSIS
+
+  use Koha::Linktracker;
+  my $tracker = Koha::Linktracker->new();
+  $tracker->trackclick( $linkinfo );
+
+=head1 DESCRIPTION
+
+=head1 FUNCTIONS
+
+=cut
+
+use Modern::Perl;
+use Carp;
+use C4::Context;
+use base qw(Class::Accessor);
+
+__PACKAGE__->mk_accessors(qw( trackingmethod ));
+
+sub trackclick {
+    my ( $self, $linkinfo ) = @_;
+    my $dbh   = C4::Context->dbh();
+    my $query = "INSERT INTO linktracker (biblionumber,itemnumber,borrowernumber
+                    ,url,timeclicked) VALUES (?,?,?,?,now())";
+    my $sth = $dbh->prepare($query);
+    $sth->execute(
+        $linkinfo->{biblionumber},   $linkinfo->{itemnumber},
+        $linkinfo->{borrowernumber}, $linkinfo->{uri}
+    );
+
+}
+
+=head2 EXPORT
+
+None by default.
+
+
+=head1 AUTHOR
+
+Chris Cormack, E<lt>chris@bigballofwax.co.nzE<gt>
+
+=cut
+
+1;
+
+__END__

diff --git a/opac/tracklinks.pl b/opac/tracklinks.pl
index 5c07cdd..7182fdb 100755 (executable)
--- a/opac/tracklinks.pl
+++ b/opac/tracklinks.pl
@@ -21,19 +21,23 @@
 use Modern::Perl;
 use C4::Context;
 use C4::Auth qw(checkauth);
+use Koha::Linktracker;
 use CGI;
 
-my $trackinglinks = C4::Context->preference('TrackClicks');
-
 my $cgi = new CGI;
 my $uri = $cgi->param('uri') || '';
 
+my $tracker = Koha::Linktracker->new(
+    { trackingmethod => C4::Context->preference('TrackClicks') } );
+
 if ($uri) {
-    if ( $trackinglinks eq 'track' || $trackinglinks eq 'anonymous' ) {
+    if (   $tracker->trackingmethod() eq 'track'
+        || $tracker->trackingmethod() eq 'anonymous' )
+    {
         my $borrowernumber = 0;
 
         # we have a uri and we want to track
-        if ( $trackinglinks eq 'track' ) {
+        if ( $tracker->trackingmethod() eq 'track' ) {
             my ( $user, $cookie, $sessionID, $flags ) =
               checkauth( $cgi, 1, {}, 'opac' );
             my $userenv = C4::Context->userenv;
@@ -50,7 +54,14 @@ if ($uri) {
         my $biblionumber = $cgi->param('biblionumber') || 0;
         my $itemnumber   = $cgi->param('itemnumber')   || 0;
 
-        trackclick( $uri, $biblionumber, $borrowernumber, $itemnumber );
+        $tracker->trackclick(
+            {
+                uri            => $uri,
+                biblionumber   => $biblionumber,
+                borrowernumber => $borrowernumber,
+                itemnumber     => $itemnumber
+            }
+        );
         print $cgi->redirect($uri);
     }
     else {
@@ -65,13 +76,3 @@ else {
     print $cgi->redirect("/cgi-bin/koha/errors/404.pl");    # escape early
     exit;
 }
-
-sub trackclick {
-    my ( $uri, $biblionumber, $borrowernumber, $itemnumber ) = @_;
-    my $dbh   = C4::Context->dbh();
-    my $query = "INSERT INTO linktracker (biblionumber,itemnumber,borrowernumber
-    ,url,timeclicked) VALUES (?,?,?,?,now())";
-    my $sth = $dbh->prepare($query);
-    $sth->execute( $biblionumber, $itemnumber, $borrowernumber, $uri );
-
-}