Bug 14504: (QA followup) fix test transaction, book_on_loan

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl
index f3d3de6..0e9e8d1 100755 (executable)
--- a/misc/cronjobs/delete_items.pl
+++ b/misc/cronjobs/delete_items.pl
@@ -58,7 +58,7 @@ $GLOBAL->{sth}->{target_items}->execute();
 DELITEM: while ( my $item = $GLOBAL->{sth}->{target_items}->fetchrow_hashref() ) {
 
     my $status = C4::Items::ItemSafeToDelete( $item->{itemnumber}, $item->{biblionumber} );
-    if( $status == 1 )  {
+    if( $status eq '1' )  {
         C4::Items::DelItemCheck( $item->{itemnumber}, $item->{biblionumber} );
         verbose "Deleting '$item->{itemnumber}'";
     } else {

diff --git a/t/db_dependent/Circulation/IsItemIssued.t b/t/db_dependent/Circulation/IsItemIssued.t
index 907a3cf..bafc405 100644 (file)
--- a/t/db_dependent/Circulation/IsItemIssued.t
+++ b/t/db_dependent/Circulation/IsItemIssued.t
@@ -58,6 +58,8 @@ is(
     'item that is not on loan can be deleted',
 );
 
+$schema->storage->txn_rollback;
+
 # C4::Context->userenv
 sub Mock_userenv {
     return { branch => $library->{branchcode} };