net: dsa: mv88e6xxx: bitwise vs logical bug
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 14 Aug 2018 09:06:43 +0000 (12:06 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Aug 2018 17:03:30 +0000 (10:03 -0700)
We are trying to test if these flags are set but there are some && vs &
typos.

Fixes: efd1ba6af93f ("net: dsa: mv88e6xxx: Add SERDES phydev_mac_change up for 6390")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/serdes.c

index f007d10..e829839 100644 (file)
@@ -502,8 +502,8 @@ static irqreturn_t mv88e6390_serdes_thread_fn(int irq, void *dev_id)
                err = mv88e6390_serdes_irq_status_sgmii(chip, lane, &status);
                if (err)
                        goto out;
-               if (status && (MV88E6390_SGMII_INT_LINK_DOWN ||
-                              MV88E6390_SGMII_INT_LINK_UP)) {
+               if (status & (MV88E6390_SGMII_INT_LINK_DOWN |
+                             MV88E6390_SGMII_INT_LINK_UP)) {
                        ret = IRQ_HANDLED;
                        mv88e6390_serdes_irq_link_sgmii(chip, port->port, lane);
                }