dccp: fix memory leak during tear-down of unsuccessful connection request
authorHannes Frederic Sowa <hannes@stressinduktion.org>
Sun, 12 Mar 2017 23:01:30 +0000 (00:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Mar 2017 05:00:42 +0000 (22:00 -0700)
This patch fixes a memory leak, which happens if the connection request
is not fulfilled between parsing the DCCP options and handling the SYN
(because e.g. the backlog is full), because we forgot to free the
list of ack vectors.

Reported-by: Jianwen Ji <jiji@redhat.com>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/ccids/ccid2.c

index f053198..5e3a730 100644 (file)
@@ -749,6 +749,7 @@ static void ccid2_hc_tx_exit(struct sock *sk)
        for (i = 0; i < hc->tx_seqbufc; i++)
                kfree(hc->tx_seqbuf[i]);
        hc->tx_seqbufc = 0;
+       dccp_ackvec_parsed_cleanup(&hc->tx_av_chunks);
 }
 
 static void ccid2_hc_rx_packet_recv(struct sock *sk, struct sk_buff *skb)