Remove an instance of CGI::scrolling_list from this file
To test:
1) Go to Reports, Guided report wizard, New SQL report
2) Create a report with some auth value list, e.g.
SELECT surname,firstname FROM borrowers WHERE branchcode=<<Enter patrons library|branches>>
Save
3) Clic on 'Run this report", look at the dropdown, that will be changed
4) Apply the patch
5) Reload, check dropdown and any regression
Followed test plan, works as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
[% ELSIF ( sql_param.input == 'text' ) %]
<li><label for="sql_params[% loop.count %]">[% sql_param.entry %]: </label><input id="sql_params[% loop.count %]" type="text" name="sql_params" /></li>
[% ELSE %]
- <li><label for="sql_params_[% sql_param.labelid %]">[% sql_param.entry %]:</label> [% sql_param.input %]</li>
+ <li><label for="sql_params_[% sql_param.labelid %]">[% sql_param.entry %]:</label>
+ <select name="[%- sql_param.input.name -%]" tabindex="1" size="1" id="[%- sql_param.input.id -%]">
+ [% FOREACH value IN sql_param.input.values %]
+ <option value="[%- value -%]">[%- sql_param.input.labels.$value -%]</option>
+ [% END %]
+ </select>
+ </li>
[% END %]
[% END %]
</ol>
}
$labelid = $text;
$labelid =~ s/\W//g;
- $input =CGI::scrolling_list( # FIXME: factor out scrolling_list
- -name => "sql_params",
- -id => "sql_params_".$labelid,
- -values => \@authorised_values,
-# -default => $value,
- -labels => \%authorised_lib,
- -override => 1,
- -size => 1,
- -multiple => 0,
- -tabindex => 1,
- );
+ $input = {
+ name => "sql_params",
+ id => "sql_params_".$labelid,
+ values => \@authorised_values,
+ labels => \%authorised_lib,
+ };
}
push @tmpl_parameters, {'entry' => $text, 'input' => $input, 'labelid' => $labelid };