Bug 9605: rotating collections permissions are wrong

In tools / rotating collections, permissions are 'parameters => 1'.
But there is a dedicated permission : tools => rotating_collections.

Test plan :
- Disable tools/rotating_collections permission to your connected user
- Check you dont have access to those pages :
  rotating_collections/addItems.pl
  rotating_collections/editCollections.pl
  rotating_collections/rotatingCollections.pl
  rotating_collections/transferCollection.pl
- Enable tools/rotating_collections permission to your connected user
- Check you have access to above pages

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes wrong permission on rotating collection related pages.
This will allow to block access to those.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>

diff --git a/rotating_collections/addItems.pl b/rotating_collections/addItems.pl
index ae7070f..06b6b3a 100755 (executable)
--- a/rotating_collections/addItems.pl
+++ b/rotating_collections/addItems.pl
@@ -34,7 +34,7 @@ my ($template, $loggedinuser, $cookie)
                             query => $query,
                             type => "intranet",
                             authnotrequired => 0,
-                            flagsrequired => {parameters => 1},
+                          flagsrequired => { tools => 'rotating_collections' },
                             debug => 1,
                             });
 

diff --git a/rotating_collections/editCollections.pl b/rotating_collections/editCollections.pl
index 4c4849c..e386608 100755 (executable)
--- a/rotating_collections/editCollections.pl
+++ b/rotating_collections/editCollections.pl
@@ -33,7 +33,7 @@ my ($template, $loggedinuser, $cookie)
                             query => $query,
                             type => "intranet",
                             authnotrequired => 0,
-                            flagsrequired => {parameters => 1},
+                          flagsrequired => { tools => 'rotating_collections' },
                             debug => 1,
                             });
 

diff --git a/rotating_collections/rotatingCollections.pl b/rotating_collections/rotatingCollections.pl
index 52ee5ee..35aea56 100755 (executable)
--- a/rotating_collections/rotatingCollections.pl
+++ b/rotating_collections/rotatingCollections.pl
@@ -33,7 +33,7 @@ my ($template, $loggedinuser, $cookie)
                             query => $query,
                             type => "intranet",
                             authnotrequired => 0,
-                            flagsrequired => {parameters => 1},
+                          flagsrequired => { tools => 'rotating_collections' },
                             debug => 1,
                             });
 

diff --git a/rotating_collections/transferCollection.pl b/rotating_collections/transferCollection.pl
index 39945d5..23eff46 100755 (executable)
--- a/rotating_collections/transferCollection.pl
+++ b/rotating_collections/transferCollection.pl
@@ -38,7 +38,7 @@ my ($template, $loggedinuser, $cookie)
                             query => $query,
                             type => "intranet",
                             authnotrequired => 0,
-                            flagsrequired => {parameters => 1},
+                          flagsrequired => { tools => 'rotating_collections' },
                             debug => 1,
                             });