Bug 3890: Nothing in Type Pull Down on Purchase Suggestions.

This patch adds a description of the itype next to the image that i suppose to appear in the selection list.

Fixed the path of the image in opac-suggestions.pl, but I'm not sure if you can actually display an image in a <SELECT> list option.

Also removed an extra </label> closing tag.

diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl
index a66a8ad..e03cd3d 100644 (file)
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tmpl
@@ -63,14 +63,14 @@ $.tablesorter.addParser({
     <li><label for="title">Title:</label><input type="text" id="title" name="title" size="50" maxlength="80" /></li>
     <li><label for="author">Author:</label><input type="text" id="author" name="author" size="50" maxlength="80" /></li>
     <li><label for="copyrightdate">Copyright date:</label><input type="text" id="copyrightdate" name="copyrightdate" size="4" maxlength="4" /></li>
-    <li><label for="isbn">ISBN or ISSN or other standard number:</label></label><input type="text" id="isbn" name="isbn" size="50" maxlength="80" /></li>
+    <li><label for="isbn">ISBN or ISSN or other standard number:</label><input type="text" id="isbn" name="isbn" size="50" maxlength="80" /></li>
     <li><label for="publishercode">Publisher:</label><input type="text" id="publishercode" name="publishercode" size="50" maxlength="80" /></li>
     <li><label for="collectiontitle">Collection title:</label><input type="text" id="collectiontitle" name="collectiontitle" size="50" maxlength="80" /></li>
     <li><label for="place">Publication Place :</label><input type="text" id="place" name="place" size="50" maxlength="80" /></li>
     <li><label for="itemtype">Document Type:</label><select name="itemtype" >
             <option value="">Default</option>
         <!-- TMPL_LOOP name="itemtypeloop" -->
-                       <!-- TMPL_IF name="selected" --><option value="<!-- TMPL_VAR name="itemtype"-->" selected="selected"> <!--TMPL_ELSE--><option value="<!-- TMPL_VAR name="itemtype" -->"> <!--/TMPL_IF--> <!--TMPL_IF Name="imageurl"--><img alt="<!-- TMPL_VAR name="description" -->" src="<!--TMPL_VAR Name="imageurl"-->"><!--TMPL_ELSE--><!-- TMPL_VAR name="description" --><!--/TMPL_IF--></option>
+                       <!-- TMPL_IF name="selected" --><option value="<!-- TMPL_VAR name="itemtype"-->" selected="selected"> <!--TMPL_ELSE--><option value="<!-- TMPL_VAR name="itemtype" -->"> <!--/TMPL_IF--> <!--TMPL_IF Name="imageurl"--><img alt="<!-- TMPL_VAR name="description" -->" src="<!--TMPL_VAR Name="imageurl"-->" /><!-- TMPL_VAR name="description" --><!--TMPL_ELSE--><!-- TMPL_VAR name="description" --><!--/TMPL_IF--></option>
         <!-- /TMPL_LOOP -->
         </select> </li>
     <li><label for="note">Notes:</label><textarea name="note" id="note" rows="5" cols="40"></textarea></li>

diff --git a/opac/opac-suggestions.pl b/opac/opac-suggestions.pl
index 7c07c9f..8a43353 100755 (executable)
--- a/opac/opac-suggestions.pl
+++ b/opac/opac-suggestions.pl
@@ -66,7 +66,7 @@ if ($allsuggestions){
 else {
        $$suggestion{suggestedby} ||= $borrowernumber unless ($allsuggestions);
 }
-warn "bornum:",$borrowernumber;
+# warn "bornum:",$borrowernumber;
 use YAML;
 my $suggestions_loop =
   &SearchSuggestion( $suggestion);
@@ -97,7 +97,7 @@ map{ $_->{'branchcodesuggestedby'}=GetBranchInfo($_->{'branchcodesuggestedby'})-
 my $supportlist=GetSupportList();                              
 foreach my $support(@$supportlist){
        if ($$support{'imageurl'}){
-               $$support{'imageurl'}= getitemtypeimagelocation( 'intranet', $$support{'imageurl'} );
+               $$support{'imageurl'}= getitemtypeimagelocation( 'opac', $$support{'imageurl'} );
        }
        else {
           delete $$support{'imageurl'}