bug 3212: MARC21 bib leader plugin sets Leader/09 to 'a'

Changed the plugin so that the form for editing the MARC21
leader now sets postion 9 (character coding) to 'a' (UCS/Unicode)
and no longer gives the cataloger the option to change it.  Koha
uses UTF-8 exclusively for MARC records, and a number of bugs
can be triggered by storing MARC21 bib and authority record
whose Leader/09 is anything other than 'a'.  Since internal
routines are increasingly ensuring that the MARC21 Leader/09 is
set to 'a', it doesn't make sense to give catalogers the idea
that it's possible (or a good idea) to set the Leader/09 to any
other value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>

diff --git a/cataloguing/value_builder/marc21_leader.pl b/cataloguing/value_builder/marc21_leader.pl
index c4abb5c..2598be7 100755 (executable)
--- a/cataloguing/value_builder/marc21_leader.pl
+++ b/cataloguing/value_builder/marc21_leader.pl
@@ -86,7 +86,6 @@ my ($template, $loggedinuser, $cookie)
        my $f6 = substr($result,6,1);
        my $f7 = substr($result,7,1);
        my $f8 = substr($result,8,1);
-       my $f9 = substr($result,9,1);
        my $f17 = substr($result,17,1);
        my $f18 = substr($result,18,1);
        my $f19 = substr($result,19,1);
@@ -96,7 +95,6 @@ my ($template, $loggedinuser, $cookie)
                                                        "f6$f6" => 1,
                                                        "f7$f7" => 1,
                                                        "f8$f8" => 1,
-                                                       "f9$f9" => 1,
                                                        "f17$f17" => 1,
                                                        "f18$f18" => 1,
                                                        "f19$f19" => 1,

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tmpl
index 42047f7..d6d578c 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader.tmpl
@@ -183,20 +183,7 @@
 
        <tr>
                <td>9- Character coding scheme</td>
-               <td>
-                       <select name="f9" size="1">
-                               <!-- TMPL_IF name="f9 " -->
-                                       <option value=" " selected="selected">MARC-8</option>
-                               <!-- TMPL_ELSE -->
-                                       <option value=" ">MARC-8</option>
-                               <!-- /TMPL_IF -->
-                               <!-- TMPL_IF name="f9a" -->
-                                       <option value="a" selected="selected">a- UCS/Unicode</option>
-                               <!-- TMPL_ELSE -->
-                                       <option value="a">a- UCS/Unicode</option>
-                               <!-- /TMPL_IF -->
-                       </select>
-               </td>
+               <td>a - UCS/Unicode (auto-filled)</td>
        </tr>
        <tr>
                <td>10-16 indicator/subfields/size</td>
@@ -335,7 +322,7 @@ function report() {
                        document.f_pop.f6.value+
                        document.f_pop.f7.value+
                        document.f_pop.f8.value+
-                       document.f_pop.f9.value+ 
+                       'a'+ // MARC21 UNICODE flag - must be 'a' for Koha
                        '22     '+
                        document.f_pop.f17.value+
                        document.f_pop.f18.value+