Bug 19784: Remove reference to 'borrowernumber' param from other endpoints

This patch removes the $ref occurences for borrowernumber in not
patron-specific endpoints. 'borrowernumber' is still used on them, but as a
hardcoded parameter. The param rename will happen on a separate bug for
each endpoint.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/api/v1/swagger/definitions/hold.json b/api/v1/swagger/definitions/hold.json
index 8f91aed..626910b 100644 (file)
--- a/api/v1/swagger/definitions/hold.json
+++ b/api/v1/swagger/definitions/hold.json
@@ -5,7 +5,8 @@
       "$ref": "../x-primitives.json#/reserve_id"
     },
     "borrowernumber": {
-      "$ref": "../x-primitives.json#/borrowernumber"
+      "type": "integer",
+      "description": "Internal patron identifier"
     },
     "reservedate": {
       "type": ["string", "null"],

diff --git a/api/v1/swagger/paths/holds.json b/api/v1/swagger/paths/holds.json
index 6bbcd40..453533a 100644 (file)
--- a/api/v1/swagger/paths/holds.json
+++ b/api/v1/swagger/paths/holds.json
@@ -12,7 +12,10 @@
           "type": "integer"
         },
         {
-          "$ref": "../parameters.json#/borrowernumberQueryParam"
+          "name": "borrowernumber",
+          "in": "query",
+          "description": "Internal patron identifier",
+          "type": "integer"
         },
         {
           "name": "reservedate",
@@ -171,7 +174,7 @@
             "type": "object",
             "properties": {
               "borrowernumber": {
-                "description": "Borrower internal identifier",
+                "description": "Internal patron identifier",
                 "type": "integer"
               },
               "biblionumber": {

diff --git a/api/v1/swagger/paths/illrequests.json b/api/v1/swagger/paths/illrequests.json
index 21fd76b..13ec426 100644 (file)
--- a/api/v1/swagger/paths/illrequests.json
+++ b/api/v1/swagger/paths/illrequests.json
@@ -39,7 +39,11 @@
                 "required": false,
                 "type": "integer"
             }, {
-                "$ref": "../parameters.json#/borrowernumberQueryParam"
+                "name": "borrowernumber",
+                "in": "query",
+                "description": "Internal patron identifier",
+                "required": false,
+                "type": "integer"
             }, {
                 "name": "completed",
                 "in": "query",