[PATCH] selinux endianness annotations
authorAl Viro <viro@hera.kernel.org>
Mon, 4 Dec 2006 22:00:55 +0000 (22:00 +0000)
committerLinus Torvalds <torvalds@woody.osdl.org>
Tue, 5 Dec 2006 03:32:44 +0000 (19:32 -0800)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
security/selinux/avc.c
security/selinux/hooks.c
security/selinux/include/avc.h

index 74c0319..e73ac1a 100644 (file)
@@ -496,7 +496,7 @@ static inline void avc_print_ipv6_addr(struct audit_buffer *ab,
                audit_log_format(ab, " %s=%d", name2, ntohs(port));
 }
 
-static inline void avc_print_ipv4_addr(struct audit_buffer *ab, u32 addr,
+static inline void avc_print_ipv4_addr(struct audit_buffer *ab, __be32 addr,
                                       __be16 port, char *name1, char *name2)
 {
        if (addr)
index a29d78d..78f98fe 100644 (file)
@@ -3537,7 +3537,7 @@ static int selinux_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
                goto out;
 
        /* Handle mapped IPv4 packets arriving via IPv6 sockets */
-       if (family == PF_INET6 && skb->protocol == ntohs(ETH_P_IP))
+       if (family == PF_INET6 && skb->protocol == htons(ETH_P_IP))
                family = PF_INET;
 
        AVC_AUDIT_DATA_INIT(&ad, NET);
index 960ef18..6ed10c3 100644 (file)
@@ -54,12 +54,12 @@ struct avc_audit_data {
                        char *netif;
                        struct sock *sk;
                        u16 family;
-                       u16 dport;
-                       u16 sport;
+                       __be16 dport;
+                       __be16 sport;
                        union {
                                struct {
-                                       u32 daddr;
-                                       u32 saddr;
+                                       __be32 daddr;
+                                       __be32 saddr;
                                } v4;
                                struct {
                                        struct in6_addr daddr;