Bug 20144: [sql_modes] Remove useless ORDER BY clauses in tests
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 6 Feb 2018 16:36:42 +0000 (13:36 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 13 Feb 2018 16:58:59 +0000 (13:58 -0300)
Fix for:
Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
t/db_dependent/Creators/Lib.t

index 858b886..c820fb7 100644 (file)
@@ -403,7 +403,6 @@ $templates = get_all_templates( { orderby => 'rows DESC' } );
 $query = '
   SELECT    count(*)
   FROM      creator_templates
-  ORDER BY  rows DESC
   ';
 $count = $dbh->selectrow_array($query);
 is( $count,      2,      'There are 2 templates' );
@@ -579,7 +578,6 @@ $layouts = get_all_layouts( { orderby => 'font_size DESC' } );
 $query = '
   SELECT   count(*)
   FROM     creator_layouts
-  ORDER BY font_size DESC
   ';
 $count = $dbh->selectrow_array($query);
 is( $count,    2,      'There are layout matching' );