Introducing new "Letters" system : Letters will be used everytime you want to sent...
authortipaul <tipaul>
Thu, 28 Jul 2005 15:10:12 +0000 (15:10 +0000)
committertipaul <tipaul>
Thu, 28 Jul 2005 15:10:12 +0000 (15:10 +0000)
the letter table contains 3 fields :
* code => the code of the letter
* name => the complete name of the letter
* content => the complete text. It's a TEXT field type, so has no limits.

My next goal now is to work on point 2-I "serial issue alert"
With this feature, in serials, a user can subscribe the "issue alert". For every issue arrived/missing, a mail is sent to all subscribers of this list. The mail warns the user that the issue is arrive or missing. Will be in head.
(see mail on koha-devel, 2005/04/07)

The "serial issue alert" will be the 1st to use this letter system that probably needs some tweaking ;-)

Once it will be stabilised default letters (in any languages) could be added during installer to help the library begin with this new feature.

admin/letter.pl [new file with mode: 0755]
koha-tmpl/intranet-tmpl/default/en/help/admin/letter.tmpl [new file with mode: 0644]
koha-tmpl/intranet-tmpl/default/en/parameters/letter.tmpl [new file with mode: 0644]
updater/updatedatabase

diff --git a/admin/letter.pl b/admin/letter.pl
new file mode 100755 (executable)
index 0000000..1f87dc0
--- /dev/null
@@ -0,0 +1,211 @@
+#!/usr/bin/perl
+
+#script to administer the aqbudget table
+#written 20/02/2002 by paul.poulain@free.fr
+# This software is placed under the gnu General Public License, v2 (http://www.gnu.org/licenses/gpl.html)
+
+# ALGO :
+# this script use an $op to know what to do.
+# if $op is empty or none of the above values,
+#      - the default screen is build (with all records, or filtered datas).
+#      - the   user can clic on add, modify or delete record.
+# if $op=add_form
+#      - if primkey exists, this is a modification,so we read the $primkey record
+#      - builds the add/modify form
+# if $op=add_validate
+#      - the user has just send datas, so we create/modify the record
+# if $op=delete_form
+#      - we show the record having primkey=$primkey and ask for deletion validation form
+# if $op=delete_confirm
+#      - we delete the record having primkey=$primkey
+
+
+# Copyright 2000-2002 Katipo Communications
+#
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it under the
+# terms of the GNU General Public License as published by the Free Software
+# Foundation; either version 2 of the License, or (at your option) any later
+# version.
+#
+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
+# Suite 330, Boston, MA  02111-1307 USA
+
+use strict;
+use CGI;
+use C4::Date;
+use C4::Auth;
+use C4::Context;
+use C4::Output;
+use C4::Interface::CGI::Output;
+use C4::Search;
+use HTML::Template;
+
+sub StringSearch  {
+       my ($env,$searchstring,$type)=@_;
+       my $dbh = C4::Context->dbh;
+       $searchstring=~ s/\'/\\\'/g;
+       my @data=split(' ',$searchstring);
+       my $count=@data;
+       my $sth=$dbh->prepare("Select * from letter where (code like ?) order by code");
+       $sth->execute("$data[0]%");
+       my @results;
+       my $cnt=0;
+       while (my $data=$sth->fetchrow_hashref){
+       push(@results,$data);
+       $cnt ++;
+       }
+       #  $sth->execute;
+       $sth->finish;
+       return ($cnt,\@results);
+}
+
+my $input = new CGI;
+my $searchfield=$input->param('searchfield');
+my $offset=$input->param('offset');
+my $script_name="/cgi-bin/koha/admin/letter.pl";
+my $code=$input->param('code');
+my $pagesize=20;
+my $op = $input->param('op');
+$searchfield=~ s/\,//g;
+my $dbh = C4::Context->dbh;
+
+my ($template, $borrowernumber, $cookie)
+    = get_template_and_user({template_name => "parameters/letter.tmpl",
+                            query => $input,
+                            type => "intranet",
+                            authnotrequired => 0,
+                            flagsrequired => {tools => 1},
+                            debug => 1,
+                            });
+
+if ($op) {
+$template->param(script_name => $script_name,
+                                               $op              => 1); # we show only the TMPL_VAR names $op
+} else {
+$template->param(script_name => $script_name,
+                                               else              => 1); # we show only the TMPL_VAR names $op
+}
+
+$template->param(action => $script_name);
+################## ADD_FORM ##################################
+# called by default. Used to create form to add or  modify a record
+if ($op eq 'add_form') {
+       #---- if primkey exists, it's a modify action, so read values to modify...
+       my $letter;
+       if ($code) {
+               my $sth=$dbh->prepare("select * from letter where code=?");
+               $sth->execute($code);
+               $letter=$sth->fetchrow_hashref;
+               $sth->finish;
+       }
+       # build field list
+       my @SQLfieldname;
+       my $sth2=$dbh->prepare("SHOW COLUMNS from biblio");
+       $sth2->execute;
+       my %line = ('value' => "", 'text' => '---BIBLIO---');
+       push @SQLfieldname, \%line;
+       while ((my $field) = $sth2->fetchrow_array) {
+               my %line = ('value' => "biblio.".$field, 'text' => "biblio.".$field);
+               warn "$line{value}";
+               push @SQLfieldname, \%line;
+       }
+       my $sth2=$dbh->prepare("SHOW COLUMNS from biblioitems");
+       $sth2->execute;
+       my %line = ('value' => "", 'text' => '---BIBLIOITEMS---');
+       push @SQLfieldname, \%line;
+       while ((my $field) = $sth2->fetchrow_array) {
+               my %line = ('value' => "biblioitems.".$field, 'text' => "biblioitems.".$field);
+               warn "$line{value}";
+               push @SQLfieldname, \%line;
+       }
+       my %line = ('value' => "", 'text' => '---ITEMS---');
+       push @SQLfieldname, \%line;
+       my %line = ('value' => "items.content", 'text' => 'items.content');
+       push @SQLfieldname, \%line;
+       
+       my $sth2=$dbh->prepare("SHOW COLUMNS from borrowers");
+       $sth2->execute;
+       my %line = ('value' => "", 'text' => '---BORROWERS---');
+       push @SQLfieldname, \%line;
+       while ((my $field) = $sth2->fetchrow_array) {
+               my %line = ('value' => "borrowers.".$field, 'text' => "borrowers.".$field);
+               warn "$line{value}";
+               push @SQLfieldname, \%line;
+       }
+       if ($code) {
+           $template->param(modify => 1);
+           $template->param(code => $letter->{code});
+       } else {
+           $template->param(adding => 1);
+       }
+       $template->param(name => $letter->{name},
+                                       content => $letter->{content},
+                                       SQLfieldname => \@SQLfieldname,);
+                                                                                                       # END $OP eq ADD_FORM
+################## ADD_VALIDATE ##################################
+# called by add_form, used to insert/modify data in DB
+} elsif ($op eq 'add_validate') {
+       my $dbh = C4::Context->dbh;
+       my $sth=$dbh->prepare("replace letter (code,name,content) values (?,?,?)");
+       $sth->execute($input->param('code'),$input->param('name'),$input->param('content'));
+       $sth->finish;
+        print $input->redirect("letter.pl");
+        exit;
+# END $OP eq ADD_VALIDATE
+################## DELETE_CONFIRM ##################################
+# called by default form, used to confirm deletion of data in DB
+} elsif ($op eq 'delete_confirm') {
+       my $dbh = C4::Context->dbh;
+       my $sth=$dbh->prepare("select * from letter where code=?");
+       $sth->execute($code);
+       my $data=$sth->fetchrow_hashref;
+       $sth->finish;
+       $template->param(code => $code);
+       $template->param(name => $data->{'name'});
+       $template->param(content => $data->{'content'});
+                                                                                                       # END $OP eq DELETE_CONFIRM
+################## DELETE_CONFIRMED ##################################
+# called by delete_confirm, used to effectively confirm deletion of data in DB
+} elsif ($op eq 'delete_confirmed') {
+       my $dbh = C4::Context->dbh;
+       my $code=uc($input->param('code'));
+       my $sth=$dbh->prepare("delete from letter where code=?");
+       $sth->execute($code);
+       $sth->finish;
+        print $input->redirect("letter.pl");
+        return;
+                                                                                                       # END $OP eq DELETE_CONFIRMED
+################## DEFAULT ##################################
+} else { # DEFAULT
+       if  ($searchfield ne '') {
+               $template->param(search => 1);
+               $template->param(searchfield => $searchfield);
+       }
+       my $env;
+       my ($count,$results)=StringSearch($env,$searchfield,'web');
+       my $toggle="white";
+       my @loop_data =();
+       for (my $i=$offset; $i < ($offset+$pagesize<$count?$offset+$pagesize:$count); $i++){
+               if ($toggle eq 'white'){
+                       $toggle="#ffffcc";
+               } else {
+                       $toggle="white";
+               }
+          my %row_data;
+          $row_data{toggle} = $toggle;
+          $row_data{code} = $results->[$i]{'code'};
+          $row_data{name} = $results->[$i]{'name'};
+          push(@loop_data, \%row_data);
+       }
+       $template->param(letter => \@loop_data);
+} #---- END $OP eq DEFAULT
+
+output_html_with_http_headers $input, $cookie, $template->output;
+
diff --git a/koha-tmpl/intranet-tmpl/default/en/help/admin/letter.tmpl b/koha-tmpl/intranet-tmpl/default/en/help/admin/letter.tmpl
new file mode 100644 (file)
index 0000000..55a4536
--- /dev/null
@@ -0,0 +1,49 @@
+<!-- TMPL_INCLUDE name="help-top.inc" -->
+
+<h1>Letter administration</h1>
+
+<p>In this part of Koha, you can define "letters".</p>
+<p>Letters will be used everytime you want to sent something to someone (through mail or paper). For example, sending a mail for overdues use letter that you can put as parameters. Sending a mail to a borrower when a suggestion is validated uses a letter too.</p>
+<p>Letter contains specific "meta-tags" that are related to fields that will be replaced by a value at runtime. Here is a list of fields that can be used :</p>
+<p>General</p>
+<ul>
+       <li>date</li>
+       <li>LibraryName</li>
+</ul>
+<p>catalogue information</p>
+<ul>
+       <li>biblio.biblionumber</li>
+       <li>biblio.title</li>
+       <li>biblio.unititle</li>
+       <li>biblio.notes</li>
+       <li>biblio.serial</li>
+       <li>biblio.seriestitle</li>
+       <li>biblio.copyrightdate</li>
+       <li>biblio.abstract</li>
+       <li>biblioitems.volume</li>
+       <li>biblioitems.number</li>
+       <li>biblioitems.classification</li>
+       <li>biblioitems.itemtype</li>
+       <li>biblioitems.isbn</li>
+       <li>biblioitems.issn</li>
+       <li>biblioitems.dewey</li>
+       <li>biblioitems.subclass</li>
+       <li>biblioitems.publicationyear</li>
+       <li>biblioitems.publishercode</li>
+       <li>biblioitems.volumedate</li>
+       <li>biblioitems.volumedesc</li>
+       <li>biblioitems.illus</li>
+       <li>biblioitems.pages</li>
+       <li>biblioitems.notes</li>
+       <li>biblioitems.size</li>
+       <li>biblioitems.place</li>
+       <li>biblioitems.lccn</li>
+       <li>biblioitems.url</li>
+       <li>items.content</li>
+</ul>
+<p>(items.content will contain one or more item informations, coming from items table)</p>
+<p>borrower information</p>
+<p>put borrower fields here</p>
+
+All fields must be included in &lt;&lt; and &gt;&gt;, like : &lt;&lt;biblio.title&gt;&gt;
+<!-- TMPL_INCLUDE name="help-bottom.inc" -->
\ No newline at end of file
diff --git a/koha-tmpl/intranet-tmpl/default/en/parameters/letter.tmpl b/koha-tmpl/intranet-tmpl/default/en/parameters/letter.tmpl
new file mode 100644 (file)
index 0000000..6ec13d9
--- /dev/null
@@ -0,0 +1,218 @@
+<!-- TMPL_INCLUDE NAME="parameters-top.inc" -->
+<div id="mainbloc">
+       <h1>Letters admin</h1>
+       <!-- TMPL_IF NAME="else" -->
+               <form action="/cgi-bin/koha/admin/letter.pl" method="post">
+               <input type="text" name="searchfield" value="">
+               <input type="submit" class="button" value="OK"></form>
+               <!-- TMPL_IF NAME="search" -->
+               <br>You Searched for <b><!-- TMPL_VAR NAME="searchfield" --></b><p><br>
+               <!-- /TMPL_IF -->
+               <table>
+               <tr>
+                       <th>Code</th>
+                       <th>Name</th>
+                       <th>&nbsp;</th>
+                       <th>&nbsp;</th>
+               </tr>
+               <!-- TMPL_LOOP NAME="letter" -->
+                       <tr bgcolor=<!-- TMPL_VAR NAME="toggle" --> >
+                               <td><!-- TMPL_VAR NAME="code" --></td>
+                               <td><!-- TMPL_VAR NAME="name" --></td>
+                               <td>
+                                       <a href="/cgi-bin/koha/admin/letter.pl?op=add_form&amp;code=<!-- TMPL_VAR NAME="code" -->">
+                                               <img src="<!-- TMPL_VAR NAME="interface" -->/<!-- TMPL_VAR NAME="theme" -->/images/fileopen.png"  width="32" hspace="0" vspace="0" border="0">
+                                       </a>
+                               </td>
+                               <td>
+                                       <a href="/cgi-bin/koha/admin/letter.pl?op=delete_confirm&amp;code=<!-- TMPL_VAR NAME="code" -->">
+                                               <img src="<!-- TMPL_VAR NAME="interface" -->/<!-- TMPL_VAR NAME="theme" -->/images/edittrash.png" width="32" hspace="0" vspace="0" border="0">
+                                       </a>
+                               </td>
+                       </tr>
+               <!-- /TMPL_LOOP -->
+               </table>
+               <form action="/cgi-bin/koha/admin/letter.pl" method="post">
+                       <input type="hidden" name="op" value="add_form">
+                       <br>
+                       <input type="submit" class="button" value="Add Letter" title="Add Letter" alt="Add Letter">
+                       <br>
+               </form>
+               <br clear="all">
+       <!-- /TMPL_IF -->
+       
+       <!-- TMPL_IF NAME="add_form" -->
+       <script language="javascript" type="text/javascript">
+               function _(s) { return s } // dummy function for gettext
+               /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+               function isNotNull(f,noalert) {
+                       if (f.value.length ==0) {
+       return false;
+                       }
+                       return true;
+               }
+               /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+               function toUC(f) {
+                       var x=f.value.toUpperCase();
+                       f.value=x;
+                       return true;
+               }
+               /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+               function isNum(v,maybenull) {
+               var n = new Number(v.value);
+               if (isNaN(n)) {
+                       return false;
+                       }
+               if (maybenull==0 && v.value=='') {
+                       return false;
+               }
+               return true;
+               }
+               /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+               function isDate(f) {
+                       var t = Date.parse(f.value);
+                       if (isNaN(t)) {
+                               return false;
+                       }
+               }
+               /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
+               function Check(f) {
+                       var ok=1;
+                       var _alertString="";
+                       var alertString2;
+/*                     if (!(isNotNull(window.document.Aform.code))) {
+                               _alertString += "\n- " + _("Code missing");
+                       }*/
+/*                     if (!(isNotNull(window.document.Aform.name))) {
+                               _alertString += "\n- " + _("Name missing");
+                       }*/
+                       if (_alertString.length==0) {
+                               document.Aform.submit();
+                       } else {
+                               alertString2  = _("Form not submitted because of the following problem(s)");
+                               alertString2 += "\n------------------------------------------------------------------------------------\n";
+                               alertString2 += _alertString;
+                               alert(alertString2);
+                       }
+               }
+               // GPL code coming from PhpMyAdmin
+               function insertValueQuery() {
+                       var myQuery = document.Aform.content;
+                       var myListBox = document.Aform.SQLfieldname;
+               
+                       if(myListBox.options.length > 0) {
+                               var chaineAj = "";
+                               var NbSelect = 0;
+                               for(var i=0; i<myListBox.options.length; i++) {
+                                       if (myListBox.options[i].selected){
+                                               NbSelect++;
+                                               if (NbSelect > 1)
+                                                       chaineAj += ", ";
+                                               chaineAj += myListBox.options[i].value;
+                                       }
+                               }
+               
+                               //IE support
+                               if (document.selection) {
+                                       myQuery.focus();
+                                       sel = document.selection.createRange();
+                                       sel.text = chaineAj;
+                                       document.Aform.insert.focus();
+                               }
+                               //MOZILLA/NETSCAPE support
+                               else if (document.Aform.content.selectionStart || document.Aform.content.selectionStart == "0") {
+                                       var startPos = document.Aform.content.selectionStart;
+                                       var endPos = document.Aform.content.selectionEnd;
+                                       var chaineSql = document.Aform.content.value;
+                                       myQuery.value = chaineSql.substring(0, startPos) +'<<'+ chaineAj+'>>' + chaineSql.substring(endPos, chaineSql.length);
+                               } else {
+                                       myQuery.value += chaineAj;
+                               }
+                       }
+               }
+               
+               </script>
+       <div id="bloc25">
+               <!-- TMPL_IF name="modify" -->
+                       <h2 class="parameters">Modify letter</h2>
+               <!-- TMPL_ELSE -->
+                       <h2 class="parameters">Add letter</h2>
+               <!-- /TMPL_IF -->
+               <form action="/cgi-bin/koha/admin/letter.pl" name="Aform" method="post">
+               <input type="hidden" name="op" value="add_validate">
+               <input type="hidden" name="checked" value="0">
+               <!-- TMPL_IF NAME="modify" -->
+                       <p>
+                               <label class="label100">Code:</label><input type="hidden" name="code" value="<!-- TMPL_VAR NAME="code" -->"><!-- TMPL_VAR NAME="code" -->
+                       </p>
+                       <p>
+                               <label class="label100">Name:</label><!-- TMPL_VAR NAME="name" -->
+                       </p>
+               <!-- /TMPL_IF -->
+               
+               <!-- TMPL_IF NAME="adding" -->
+                       <p>
+                               <label class="label100">Code:</label><input type="text" name="code" size="20" maxlength="20">
+                       </p>
+               <!-- /TMPL_IF -->
+               
+               <p>
+                       <label class="label100">Name:</label><input type="text" name="name" size="100" value="<!-- TMPL_VAR NAME="name" -->">
+               </p>
+               <p>
+                       <label class="label100">Content:</label>
+               </p>
+               <p><textarea name="content" cols="80" rows="10"><!-- TMPL_VAR NAME="content" --></textarea>
+               <input type="button" name="insert" value="&lt;&lt;" onclick="insertValueQuery()" title="Insert" />
+               <select name="SQLfieldname" size=10>
+                       <!-- TMPL_LOOP name="SQLfieldname" -->
+                               <option value="<!-- TMPL_VAR name="value"-->"><!-- TMPL_VAR name="text"--></option>
+                       <!-- /TMPL_LOOP -->
+               </select>
+               </p>
+               <p><input type="button" value="OK" onclick="Check(this.form)" class="button"></p>
+               </form>
+       </div>
+       <!-- /TMPL_IF -->
+       
+       <!-- TMPL_IF NAME="add_validate" -->
+       Data recorded
+       <form action="<!-- TMPL_VAR NAME="action" -->" method="post">
+       <input type="submit" value="OK">
+       </form>
+       <!-- /TMPL_IF -->
+       
+       <!-- TMPL_IF NAME="delete_confirm" -->
+       <table border="0" cellspacing="0" cellpadding="5">
+               <tr valign="top" bgcolor="#99cc33">
+                       <td background="<!-- TMPL_VAR NAME="themelang" -->/images/background-mem.gif">
+                               <b>Code</b>
+                       </td>
+                       <td background="<!-- TMPL_VAR NAME="themelang" -->/images/background-mem.gif">
+                               <b><!-- TMPL_VAR NAME="code" --></b>
+                       </td>
+               </tr>
+       
+               <form action="<!-- TMPL_VAR NAME="action" -->" method="post"><input type="hidden" name="op" value="delete_confirmed">
+               <input type="hidden" name="code" value="<!-- TMPL_VAR NAME="code" -->">
+               <tr>
+                       <td>Name</td>
+                       <td><!-- TMPL_VAR NAME="Name" --></td>
+               </tr>
+               <tr>
+                       <td colspan="2" align="center">CONFIRM DELETION</td>
+               </tr>
+               <tr>
+                       <td><input type="submit" value="YES"></form></td><td><form action="<!-- TMPL_VAR NAME="action" -->" method="post"><input type="submit" value="NO"></form></td>
+               </tr>
+       </table>
+       <!-- /TMPL_IF -->
+       
+       <!-- TMPL_IF NAME="delete_confirmed" -->
+       Data deleted
+       <form action="<!-- TMPL_VAR NAME="action" -->" method="post">
+       <input type="submit" value="OK">
+       </form>
+       <!-- /TMPL_IF -->
+</div>
+<!-- TMPL_INCLUDE NAME="parameters-bottom.inc" -->
index 7ed7d40..82615f2 100755 (executable)
@@ -72,6 +72,12 @@ my %requiretables = (
                                    `info` TEXT default '' ,
                                    PRIMARY KEY ( `timestamp` , `user` )
                            )",
+       letter          => "(
+                                       code varchar(20) NOT NULL,
+                                       name varchar(100) NOT NULL,
+                                       content TEXT,
+                                       PRIMARY KEY (code)
+                               )",
 );
 
 my %requirefields = (
@@ -350,6 +356,21 @@ $sth->finish;
 exit;
 
 # $Log$
+# Revision 1.114  2005/07/28 15:10:13  tipaul
+# Introducing new "Letters" system : Letters will be used everytime you want to sent something to someone (through mail or paper). For example, sending a mail for overdues use letter that you can put as parameters. Sending a mail to a borrower when a suggestion is validated uses a letter too.
+# the letter table contains 3 fields :
+# * code => the code of the letter
+# * name => the complete name of the letter
+# * content => the complete text. It's a TEXT field type, so has no limits.
+#
+# My next goal now is to work on point 2-I "serial issue alert"
+# With this feature, in serials, a user can subscribe the "issue alert". For every issue arrived/missing, a mail is sent to all subscribers of this list. The mail warns the user that the issue is arrive or missing. Will be in head.
+# (see mail on koha-devel, 2005/04/07)
+#
+# The "serial issue alert" will be the 1st to use this letter system that probably needs some tweaking ;-)
+#
+# Once it will be stabilised default letters (in any languages) could be added during installer to help the library begin with this new feature.
+#
 # Revision 1.113  2005/07/28 08:38:41  tipaul
 # For instance, the return date does not rely on the borrower expiration date. A systempref will be added in Koha, to modify return date calculation schema :
 # * ReturnBeforeExpiry = yes => return date can't be after expiry date
@@ -716,6 +737,21 @@ $sth->finish;
 exit;
 
 # $Log$
+# Revision 1.114  2005/07/28 15:10:13  tipaul
+# Introducing new "Letters" system : Letters will be used everytime you want to sent something to someone (through mail or paper). For example, sending a mail for overdues use letter that you can put as parameters. Sending a mail to a borrower when a suggestion is validated uses a letter too.
+# the letter table contains 3 fields :
+# * code => the code of the letter
+# * name => the complete name of the letter
+# * content => the complete text. It's a TEXT field type, so has no limits.
+#
+# My next goal now is to work on point 2-I "serial issue alert"
+# With this feature, in serials, a user can subscribe the "issue alert". For every issue arrived/missing, a mail is sent to all subscribers of this list. The mail warns the user that the issue is arrive or missing. Will be in head.
+# (see mail on koha-devel, 2005/04/07)
+#
+# The "serial issue alert" will be the 1st to use this letter system that probably needs some tweaking ;-)
+#
+# Once it will be stabilised default letters (in any languages) could be added during installer to help the library begin with this new feature.
+#
 # Revision 1.113  2005/07/28 08:38:41  tipaul
 # For instance, the return date does not rely on the borrower expiration date. A systempref will be added in Koha, to modify return date calculation schema :
 # * ReturnBeforeExpiry = yes => return date can't be after expiry date