Bug 16032 - Use Font Awesome icon in "note" styled divs

Several pages use <div class="note"> to display important information
about the functionality on the page. The style of this div can be
modified to use Font Awesome, eliminating an image file.

To test, apply the patch and clear your browser cache if necessary.

- Go to Administration -> Authorized values.
- Confirm that the "NOTE" box is styled correctly.
- Edit an existing authorized value.
- Confirm that the "NOTE" box is styled correctly.

- Go to Tools -> Batch record deletion.
- Submit a batch of biblionumbers.
- Confirm that the "Reminder" box is styled correctly.
- Go back and submit a batch of authority numbers.
- Confirm that the "Reminder" box is styled correctly.

- Go to Tools -> Batch record modification.
- Submit a batch of biblionumbers.
- Confirm that the "Reminder" box is styled correctly.
- Go back and submit a batch of authority numbers.
- Confirm that the "Reminder" box is styled correctly.

- Check that there are no other references to "note.png" in the
  templates.

Followed test plan, works as expected
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
index 25c0714..a0b3bd3 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
@@ -1243,22 +1243,25 @@ div.message ul+h4 {
 }
 
 div.note {
-       background: #f4f6fa;
-       background-repeat : no-repeat;
-       background-position : left center;
-       background-image : url("../../img/note.png");
-       background-image: url("../../img/note.png"), -moz-linear-gradient(top, #f4f6fa 0%, #e8edf6 100%); /* FF3.6+ */
-       background-image: url("../../img/note.png"), -webkit-gradient(linear, left top, left bottom, color-stop(0%,#f4f6fa), color-stop(100%,#e8edf6)); /* Chrome,Safari4+ */
-       background-image: url("../../img/note.png"), -webkit-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* Chrome10+,Safari5.1+ */
-       background-image: url("../../img/note.png"), -o-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* Opera11.10+ */
-       background-image: url("../../img/note.png"), -ms-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* IE10+ */
-       filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#f4f6fa', endColorstr='#e8edf6',GradientType=0 ); /* IE6-9 */
-       background-image: url("../../img/note.png"), linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* W3C */
-       border : 1px solid #BCBCBC;
-       padding : .5em .5em .5em 20px;
-       margin : .5em 0;
+    background: #f4f6fa;
+    background: -moz-linear-gradient(top, #f4f6fa 0%, #e8edf6 100%); /* FF3.6+ */
+    background: -webkit-gradient(linear, left top, left bottom, color-stop(0%,#f4f6fa), color-stop(100%,#e8edf6)); /* Chrome,Safari4+ */
+    background: -webkit-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* Chrome10+,Safari5.1+ */
+    background: -o-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* Opera11.10+ */
+    background: -ms-linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* IE10+ */
+    filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#f4f6fa', endColorstr='#e8edf6',GradientType=0 ); /* IE6-9 */
+    background: linear-gradient(top, #f4f6fa 0%,#e8edf6 100%); /* W3C */
+    border : 1px solid #BCBCBC;
+    padding : .5em;
+    margin : .5em 0;
 }
- 
+
+div.note i.fa-exclamation {
+    color: #cc0000;
+    font-style: italic;
+    padding: 0 0.3em;
+}
+
  div.results {
        padding : .7em 0;
  }

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
index d3a5f20..293a379 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
@@ -74,7 +74,7 @@ $(document).ready(function() {
           [% IF ( action_add_category ) %]New category[% END %]
        </h1>
 
-    [% IF ( action_modify ) %]<div class="note"><strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div>[% END %]
+    [% IF ( action_modify ) %]<div class="note"><i class="fa fa-exclamation"></i> <strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div>[% END %]
 
  <form action="/cgi-bin/koha/admin/authorised_values.pl" name="Aform" method="post">
     <input type="hidden" name="op" value="add" />
@@ -167,7 +167,7 @@ $(document).ready(function() {
 </div>
 
 <h1>Authorized values</h1>
-<div class="note"><strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div>
+<div class="note"><i class="fa fa-exclamation"></i> <strong>NOTE:</strong> If you change an authorized value code, existing records using it won't be updated. Changes to value descriptions will show immediately.</div>
 
 [% FOR m IN messages %]
     <div class="dialog [% m.type %]">

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
index 182cc8b..9df964b 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
@@ -175,7 +175,7 @@ $(document).ready(function() {
               [% END %]
             </tbody>
           </table>
-          <div class="note">Reminder: this action will delete all selected bibliographic records, attached subscriptions, existing holds, and attached items!</div>
+          <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will delete all selected bibliographic records, attached subscriptions, existing holds, and attached items!</div>
       [% ELSE %]
         <div id="toolbar">
           <a id="selectall" href="#">Select all</a>
@@ -203,7 +203,7 @@ $(document).ready(function() {
               [% END %]
             </tbody>
           </table>
-          <div class="note">Reminder: this action will delete all selected authorities!</div>
+          <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will delete all selected authorities!</div>
       [% END %]
         <fieldset class="action">
           <input type="hidden" name="op" value="delete" />

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
index ea00c36..1d95ef7 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_record_modification.tt
@@ -215,7 +215,7 @@ $(document).ready(function() {
               [% END %]
             </tbody>
           </table>
-          <div class="note">Reminder: this action will modify all selected biblios!</div>
+          <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected biblios!</div>
         [% ELSE %]
           <div id="toolbar">
             <a id="selectall" href="#">Select all</a>
@@ -241,7 +241,7 @@ $(document).ready(function() {
               [% END %]
             </tbody>
           </table>
-          <div class="note">Reminder: this action will modify all selected authorities!</div>
+          <div class="note"><i class="fa fa-exclamation"></i> Reminder: this action will modify all selected authorities!</div>
         [% END %]
         <fieldset class="action">
           <input type="hidden" name="op" value="modify" />

diff --git a/koha-tmpl/intranet-tmpl/prog/img/note.png b/koha-tmpl/intranet-tmpl/prog/img/note.png
deleted file mode 100644 (file)
index 5c3f8b6..0000000
Binary files a/koha-tmpl/intranet-tmpl/prog/img/note.png and /dev/null differ