Bug 16073: (follow-up) Fix software error in circulation.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 16 Mar 2016 09:32:58 +0000 (09:32 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Mon, 21 Mar 2016 16:07:18 +0000 (16:07 +0000)
Do not crash if the patron does not exist.

Test plan:
Access circ/circulation.pl?borrowernumber=42424242
you should get an error without this patch
With this patch, you will get an empty patron detail page (should be
fixed in another patch, but this behavior exists for a while)

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
circ/circulation.pl

index 74a7524..5cfd93f 100755 (executable)
@@ -585,12 +585,13 @@ my $view = $batch
 
 my @relatives;
 if ( $borrowernumber ) {
-    my $patron = Koha::Patrons->find( $borrower->{borrowernumber} );
-    if ( my $guarantor = $patron->guarantor ) {
-        push @relatives, $guarantor->borrowernumber;
-        push @relatives, $_->borrowernumber for $patron->siblings;
-    } else {
-        push @relatives, $_->borrowernumber for $patron->guarantees;
+    if ( my $patron = Koha::Patrons->find( $borrower->{borrowernumber} ) ) {
+        if ( my $guarantor = $patron->guarantor ) {
+            push @relatives, $guarantor->borrowernumber;
+            push @relatives, $_->borrowernumber for $patron->siblings;
+        } else {
+            push @relatives, $_->borrowernumber for $patron->guarantees;
+        }
     }
 }
 my $relatives_issues_count =