Bug 18420: Fix Budgets.t when no patron category 'S' exists
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 12 Apr 2017 14:03:10 +0000 (11:03 -0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 21 Apr 2017 14:49:24 +0000 (10:49 -0400)
No need to create Staff users here.

Test plan:
  prove t/db_dependent/Budgets.t
should return green, even if no categories.categorycode 'S' exists

Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/Budgets.t

index 0611389..d19dedf 100755 (executable)
@@ -580,13 +580,13 @@ for my $new_budget ( @new_budgets ) {
 
 # Test SetOwnerToFundHierarchy
 
-my $categorycode = 'S';
+my $patron_category = $builder->build({ source => 'Category' });
 my $branchcode = $library->{branchcode};
 my $john_doe = C4::Members::AddMember(
     cardnumber   => '123456',
     firstname    => 'John',
     surname      => 'Doe',
-    categorycode => $categorycode,
+    categorycode => $patron_category->{categorycode},
     branchcode   => $branchcode,
     dateofbirth  => '',
     dateexpiry   => '9999-12-31',
@@ -611,7 +611,7 @@ my $jane_doe = C4::Members::AddMember(
     cardnumber   => '789012',
     firstname    => 'Jane',
     surname      => 'Doe',
-    categorycode => $categorycode,
+    categorycode => $patron_category->{categorycode},
     branchcode   => $branchcode,
     dateofbirth  => '',
     dateexpiry   => '9999-12-31',