net: dsa: Do not check for NULL dst in tag parsers

dsa_switch_rcv() already tests for dst == NULL, so there is no need to duplicate
the same check within the tag receive functions.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/dsa/tag_brcm.c b/net/dsa/tag_brcm.c
index e2ed6cf..68d4fee 100644 (file)
--- a/net/dsa/tag_brcm.c
+++ b/net/dsa/tag_brcm.c
@@ -100,9 +100,6 @@ static int brcm_tag_rcv(struct sk_buff *skb, struct net_device *dev,
        int source_port;
        u8 *brcm_tag;
 
-       if (unlikely(dst == NULL))
-               goto out_drop;
-
        ds = dst->cpu_switch;
 
        skb = skb_unshare(skb, GFP_ATOMIC);

diff --git a/net/dsa/tag_dsa.c b/net/dsa/tag_dsa.c
index e42ba90..377569c 100644 (file)
--- a/net/dsa/tag_dsa.c
+++ b/net/dsa/tag_dsa.c
@@ -77,9 +77,6 @@ static int dsa_rcv(struct sk_buff *skb, struct net_device *dev,
        int source_device;
        int source_port;
 
-       if (unlikely(dst == NULL))
-               goto out_drop;
-
        skb = skb_unshare(skb, GFP_ATOMIC);
        if (skb == NULL)
                goto out;

diff --git a/net/dsa/tag_edsa.c b/net/dsa/tag_edsa.c
index 6a9b7a9..30520ff 100644 (file)
--- a/net/dsa/tag_edsa.c
+++ b/net/dsa/tag_edsa.c
@@ -90,9 +90,6 @@ static int edsa_rcv(struct sk_buff *skb, struct net_device *dev,
        int source_device;
        int source_port;
 
-       if (unlikely(dst == NULL))
-               goto out_drop;
-
        skb = skb_unshare(skb, GFP_ATOMIC);
        if (skb == NULL)
                goto out;

diff --git a/net/dsa/tag_mtk.c b/net/dsa/tag_mtk.c
index 44ae635..836c311 100644 (file)
--- a/net/dsa/tag_mtk.c
+++ b/net/dsa/tag_mtk.c
@@ -55,9 +55,6 @@ static int mtk_tag_rcv(struct sk_buff *skb, struct net_device *dev,
        int port;
        __be16 *phdr, hdr;
 
-       if (unlikely(!dst))
-               goto out_drop;
-
        skb = skb_unshare(skb, GFP_ATOMIC);
        if (!skb)
                goto out;

diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c
index 4e0dad7..6579d6d 100644 (file)
--- a/net/dsa/tag_qca.c
+++ b/net/dsa/tag_qca.c
@@ -75,9 +75,6 @@ static int qca_tag_rcv(struct sk_buff *skb, struct net_device *dev,
        int port;
        __be16 *phdr, hdr;
 
-       if (unlikely(!dst))
-               goto out_drop;
-
        skb = skb_unshare(skb, GFP_ATOMIC);
        if (!skb)
                goto out;

diff --git a/net/dsa/tag_trailer.c b/net/dsa/tag_trailer.c
index 74c9485..f5c764e 100644 (file)
--- a/net/dsa/tag_trailer.c
+++ b/net/dsa/tag_trailer.c
@@ -66,8 +66,6 @@ static int trailer_rcv(struct sk_buff *skb, struct net_device *dev,
        u8 *trailer;
        int source_port;
 
-       if (unlikely(dst == NULL))
-               goto out_drop;
        ds = dst->cpu_switch;
 
        skb = skb_unshare(skb, GFP_ATOMIC);