ubi: pr_err() strings should end with newlines
authorBen Dooks <ben.dooks@codethink.co.uk>
Wed, 26 Jul 2017 09:51:10 +0000 (10:51 +0100)
committerRichard Weinberger <richard@nod.at>
Wed, 13 Sep 2017 20:05:30 +0000 (22:05 +0200)
In ubi_attach_mtd_dev() the pr_err() calls should have their
messgaes terminated with a new-line to avoid other messages
being concatenated onto the end.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/ubi/build.c

index f9c576b..842550b 100644 (file)
@@ -825,7 +825,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
        for (i = 0; i < UBI_MAX_DEVICES; i++) {
                ubi = ubi_devices[i];
                if (ubi && mtd->index == ubi->mtd->index) {
-                       pr_err("ubi: mtd%d is already attached to ubi%d",
+                       pr_err("ubi: mtd%d is already attached to ubi%d\n",
                                mtd->index, i);
                        return -EEXIST;
                }
@@ -840,7 +840,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
         * no sense to attach emulated MTD devices, so we prohibit this.
         */
        if (mtd->type == MTD_UBIVOLUME) {
-               pr_err("ubi: refuse attaching mtd%d - it is already emulated on top of UBI",
+               pr_err("ubi: refuse attaching mtd%d - it is already emulated on top of UBI\n",
                        mtd->index);
                return -EINVAL;
        }
@@ -851,7 +851,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
                        if (!ubi_devices[ubi_num])
                                break;
                if (ubi_num == UBI_MAX_DEVICES) {
-                       pr_err("ubi: only %d UBI devices may be created",
+                       pr_err("ubi: only %d UBI devices may be created\n",
                                UBI_MAX_DEVICES);
                        return -ENFILE;
                }
@@ -861,7 +861,7 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
 
                /* Make sure ubi_num is not busy */
                if (ubi_devices[ubi_num]) {
-                       pr_err("ubi: ubi%i already exists", ubi_num);
+                       pr_err("ubi: ubi%i already exists\n", ubi_num);
                        return -EEXIST;
                }
        }