Bug 9720 : uninitialized value warnings in circulation (followup 1)

This patch corrects several uninitialized value errors.

Test plan:
- Edit a borrower
- Enter a surname using lowercase (it will be displayed uppercase by CSS) and save
=> Borrower surname is uppercase
- Edit an organisation (depends on borrower category)
- Enter a surname using lowercase (it will be displayed uppercase by CSS) and save
=> Borrower surname is uppercase
- Go to a borrower page who has today issues
- Click on More/Export today's checked in barcodes
=> You get a file to dowload

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>

diff --git a/members/memberentry.pl b/members/memberentry.pl
index 6b0e846..3e37a8c 100755 (executable)
--- a/members/memberentry.pl
+++ b/members/memberentry.pl
@@ -646,8 +646,8 @@ if ( $op eq 'duplicate' ) {
     $data{'dateexpiry'} = GetExpiryDate( $data{'categorycode'}, $data{'dateenrolled'} );
 }
 if (C4::Context->preference('uppercasesurnames')) {
-       $data{'surname'}    =uc($data{'surname'}    );
-       $data{'contactname'}=uc($data{'contactname'});
+    $data{'surname'} &&= uc( $data{'surname'} );
+    $data{'contactname'} &&= uc( $data{'contactname'} );
 }
 
 $data{debarred} = C4::Overdues::CheckBorrowerDebarred($borrowernumber);

diff --git a/members/readingrec.pl b/members/readingrec.pl
index d1cf5cf..ba94149 100755 (executable)
--- a/members/readingrec.pl
+++ b/members/readingrec.pl
@@ -50,6 +50,7 @@ my ($template, $loggedinuser, $cookie)= get_template_and_user({template_name =>
                                debug => 1,
                                });
 
+my $op = $input->param('op') || '';
 if ($input->param('cardnumber')) {
     $cardnumber = $input->param('cardnumber');
     $data = GetMember(cardnumber => $cardnumber);
@@ -70,7 +71,7 @@ foreach my $issue ( @{$issues} ) {
 }
 
 #   barcode export
-if ( $input->param('op') eq 'export_barcodes' ) {
+if ( $op eq 'export_barcodes' ) {
     my $today = C4::Dates->new();
     $today = $today->output('iso');
     my @barcodes =