Bug 18292: Remove return 1 statements in tests
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 9 Jun 2017 11:59:41 +0000 (08:59 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 15 Aug 2017 15:17:42 +0000 (12:17 -0300)
The test files do not need to return 1

Patch generated with:
perl -p -i -e "s/^1;\n//xsm" t/**/*.t

Test plan:
  git grep '^1;$' t/**/*.t
should not return any results

NOTE: does not fix C4/SIP/t, nor xt tests.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
114 files changed:
t/00-load.t
t/Auth_with_shibboleth.t
t/Biblio.t
t/Biblio/TransformHtmlToXml.t
t/Boolean.t
t/Calendar.t
t/Charset.t
t/Circulation_barcodedecode.t
t/Images.t
t/Koha.t
t/Koha/Config.t
t/Koha/Util/Normalize.t
t/Koha_MetadataRecord.t
t/Koha_Template_Plugin_Koha.t
t/Letters.t
t/Logger.t
t/Matcher.t
t/Patron.t
t/SIP/Sip.t
t/SMS.t
t/Search.t
t/SocialData.t
t/SuggestionEngine_AuthorityFile.t
t/XSLT.t
t/db_dependent/Accounts.t
t/db_dependent/Auth_with_cas.t
t/db_dependent/Auth_with_ldap.t
t/db_dependent/Barcodes_ValueBuilder.t
t/db_dependent/Biblio.t
t/db_dependent/Circulation/Branch.t
t/db_dependent/Circulation/CheckIfIssuedToPatron.t
t/db_dependent/Circulation/CheckValidBarcode.t
t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t
t/db_dependent/Circulation/IsItemIssued.t
t/db_dependent/Circulation/MarkIssueReturned.t
t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
t/db_dependent/Circulation/Returns.t
t/db_dependent/Circulation/StoreLastBorrower.t
t/db_dependent/Circulation/SwitchOnSiteCheckouts.t
t/db_dependent/Circulation/TooMany.t
t/db_dependent/Circulation/dateexpiry.t
t/db_dependent/Circulation/transfers.t
t/db_dependent/Clubs.t
t/db_dependent/Context.t
t/db_dependent/DecreaseLoanHighHolds.t
t/db_dependent/Exporter/Record.t
t/db_dependent/Filter_MARC_ViewPolicy.t
t/db_dependent/Hold.t
t/db_dependent/Holidays.t
t/db_dependent/ILSDI_Services.t
t/db_dependent/Items/MoveItemFromBiblio.t
t/db_dependent/Items_DelItemCheck.t
t/db_dependent/Koha/BiblioUtils.t
t/db_dependent/Koha/Biblios.t
t/db_dependent/Koha/Checkouts.t
t/db_dependent/Koha/Cities.t
t/db_dependent/Koha/CsvProfiles.t
t/db_dependent/Koha/Filter/EmbedItemsAvailability.t
t/db_dependent/Koha/IssuingRules.t
t/db_dependent/Koha/Item/Transfers.t
t/db_dependent/Koha/Items.t
t/db_dependent/Koha/Libraries.t
t/db_dependent/Koha/MarcSubfieldStructures.t
t/db_dependent/Koha/News.t
t/db_dependent/Koha/Notices.t
t/db_dependent/Koha/Objects.t
t/db_dependent/Koha/Patron/Attribute/Types.t
t/db_dependent/Koha/Patron/Attributes.t
t/db_dependent/Koha/Patron/Categories.t
t/db_dependent/Koha/Patron/Images.t
t/db_dependent/Koha/Patron/Messages.t
t/db_dependent/Koha/Patron/Modifications.t
t/db_dependent/Koha/Patrons.t
t/db_dependent/Koha/Ratings.t
t/db_dependent/Koha/Reviews.t
t/db_dependent/Koha/SMS_Providers.t
t/db_dependent/Koha/Suggestions.t
t/db_dependent/Koha_Elasticsearch.t
t/db_dependent/Koha_Elasticsearch_Indexer.t
t/db_dependent/Koha_Misc_Files.t
t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
t/db_dependent/Labels/t_Layout.t
t/db_dependent/Labels/t_Profile.t
t/db_dependent/Labels/t_Template.t
t/db_dependent/Members/GetAllIssues.t
t/db_dependent/Members/GetPendingIssues.t
t/db_dependent/Members/IssueSlip.t
t/db_dependent/Passwordrecovery.t
t/db_dependent/Patron/Borrower_Discharge.t
t/db_dependent/Patron/Borrower_PrevCheckout.t
t/db_dependent/Patron/Housebound.t
t/db_dependent/Patron/HouseboundProfiles.t
t/db_dependent/Patron/HouseboundRoles.t
t/db_dependent/Patron/HouseboundVisits.t
t/db_dependent/PatronLists.t
t/db_dependent/Patrons.t
t/db_dependent/QueryParser.t
t/db_dependent/RefundLostItemFeeRule.t
t/db_dependent/Reserves/GetReserveFee.t
t/db_dependent/Reserves/MultiplePerRecord.t
t/db_dependent/RotatingCollections.t
t/db_dependent/SIP/SIPServer.t
t/db_dependent/Search.t
t/db_dependent/Serials/ReNewSubscription.t
t/db_dependent/Template/Plugin/Categories.t
t/db_dependent/Templates.t
t/db_dependent/Utils/Datatables_Members.t
t/db_dependent/Utils/Datatables_Virtualshelves.t
t/db_dependent/api/v1/cities.t
t/db_dependent/db_structure.t
t/db_dependent/www/auth_values_input_www.t
t/db_dependent/www/batch.t
t/db_dependent/www/history.t
t/db_dependent/www/search_utf8.t

index 3f517f3..d813f2c 100644 (file)
@@ -106,4 +106,3 @@ sub is_testable {
 
 done_testing();
 
-1;
index ab03248..60bde68 100644 (file)
@@ -321,4 +321,3 @@ sub reset_config {
     return 1;
 }
 
-1;
index 1bf7895..8fd388f 100755 (executable)
@@ -193,4 +193,3 @@ warnings_like { $ret = UpdateTotalIssues() }
 
 ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist');
 
-1;
index 909fec3..c95c120 100644 (file)
@@ -77,4 +77,3 @@ subtest "->TransformHtmlToXml (NORMARC) tests" => sub {
     run_tests('NORMARC');
 };
 
-1;
index 7ca05f1..2c5434b 100755 (executable)
@@ -37,4 +37,3 @@ warning_like { $result = true_p([]) }
              'Invalid boolean (reference) raises warning';
 is( $result, undef, 'recognizes a reference as not a boolean' );
 
-1;
index 076eb8d..d5b8967 100755 (executable)
@@ -330,4 +330,3 @@ my $holiday_for_another_branch = DateTime->new(
     is ( $cal->is_holiday($holiday_for_another_branch), 1, 'Holiday defined for CPL should be defined as an holiday' );
 }
 
-1;
index 143c208..a3da56f 100755 (executable)
@@ -70,5 +70,3 @@ ok( Encode::is_utf8($record->subfield('100','a')) &&
     'SetUTF8Flag sets the UTF-8 flag to all subfields' );
 
 is( nsb_clean("\98Le\9c Moyen Ã‚ge"), "Le Moyen Ã‚ge", "nsb_clean removes \98 and \9c" );
-
-1;
index eff9624..8715661 100644 (file)
@@ -61,4 +61,3 @@ foreach my $filter (@filters) {
 #  ~ T, P or X followed by numeric characters
 #  ~ No checkdigit
 
-1;
index 02bcd82..338a903 100644 (file)
@@ -69,4 +69,3 @@ is( $imagenumbers[1], 3, 'imagenumber is 3' );
 
 is( $imagenumbers[4], undef, 'imagenumber undef' );
 
-1;
index dd0e4a4..b8d4346 100755 (executable)
--- a/t/Koha.t
+++ b/t/Koha.t
@@ -151,4 +151,3 @@ ok($@ eq '', 'NormalizeISSN does not throw exception when parsing invalid ISSN')
 is($issns[0], 'abc', 'Original ISSN passed through even if invalid');
 is(scalar(@issns), 1, 'zero additional variations returned of invalid ISSN');
 
-1;
index 2363fda..2ae3c25 100644 (file)
@@ -59,4 +59,3 @@ subtest 'read_from_file() tests' => sub {
     is( $result, undef, 'Returns undef on error confition' );
 };
 
-1;
index 7480c23..317ad8c 100644 (file)
@@ -82,4 +82,3 @@ subtest 'lower_case() normalizer' => sub {
         'The \'lower_case\' normalizer only makes characters lower-case' );
 };
 
-1;
index 48d9c40..0c2c53e 100755 (executable)
@@ -141,4 +141,3 @@ subtest "new() tests" => sub {
     is( $metadata_record, undef, 'record object mandatory')
 };
 
-1;
index 6bbe99f..e0e5ed2 100644 (file)
@@ -76,4 +76,3 @@ subtest "Koha::Template::Plugin::Koha::Version tests" => sub {
 
 };
 
-1;
index fb1158b..35a4b74 100755 (executable)
@@ -64,4 +64,3 @@ t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', 1);
 $letter = C4::Letters::_parseletter( undef, 'reserves', {waitingdate => "2013-01-01"} );
 is( ref($letter), 'HASH');
 
-1;
index cef4ea1..1a1d412 100644 (file)
@@ -74,4 +74,3 @@ sub mytempfile {
     return $fn;
 }
 
-1;
index 30d1b90..55b5a87 100755 (executable)
@@ -311,4 +311,3 @@ sub get_authors_matchpoint {
     return $matchpoint;
 }
 
-1;
index 3b87939..81b3f80 100755 (executable)
@@ -334,4 +334,3 @@ subtest 'Set tests' => sub {
     is( $patron->privacy,             '667789',                           'privacy field set ok' );
 };
 
-1;
index f670277..e7e0670 100755 (executable)
@@ -55,4 +55,3 @@ warning_is { $invalidTest = C4::SIP::Sip::Checksum::verify_cksum("1234567") }
             'verify_cksum prints the expected warning for an invalid checksum';
 is($invalidTest, 0, "Checksum: 1234567 is invalid as expected");
 
-1;
diff --git a/t/SMS.t b/t/SMS.t
index fca44b4..21dc75b 100755 (executable)
--- a/t/SMS.t
+++ b/t/SMS.t
@@ -60,4 +60,3 @@ $send_sms = C4::SMS->send_sms({
 });
 is( $send_sms, 1, 'send_sms returns 1' );
 
-1;
index 104e094..0959c85 100755 (executable)
@@ -170,4 +170,3 @@ subtest "_build_initial_query tests" => sub {
 };
 
 
-1;
index cf1d5ff..df14a50 100644 (file)
@@ -72,4 +72,3 @@ is( $report->{'without'}->[0]->{'original'},
 is( $report->{'without'}->[0]->{'isbn'}, '9780596526740',
     'testing get_report' );
 
-1;
index b648f31..10a5734 100755 (executable)
@@ -71,4 +71,3 @@ is_deeply($result, [ { 'search' => 'an=1234', 'relevance' => 1, 'label' => 'Cook
 
 done_testing();
 
-1;
index b902aa6..e3a7332 100755 (executable)
--- a/t/XSLT.t
+++ b/t/XSLT.t
@@ -77,4 +77,3 @@ my $matching_string = q{<syspref name="singleBranchMode">0</syspref>};
 my $sysprefs_xml = C4::XSLT::get_xslt_sysprefs();
 ok( $sysprefs_xml =~ m/$matching_string/, 'singleBranchMode has a value of 0');
 
-1;
index fcc63d3..be2b265 100644 (file)
@@ -478,4 +478,3 @@ subtest 'balance' => sub {
     $patron->delete;
 };
 
-1;
index ab21233..a58300a 100755 (executable)
@@ -67,4 +67,3 @@ is(C4::Auth_with_cas::_url_with_get_params($cgi, 'intranet'),
 
 $dbh->rollback;
 
-1;
index cf4b700..1a1c3d0 100755 (executable)
@@ -503,4 +503,3 @@ sub is_admin_bind {
 
 $schema->storage->txn_rollback();
 
-1;
index 38b181f..a116b45 100644 (file)
@@ -77,4 +77,3 @@ is($scr, undef, 'annual javascript');
 
 $schema->storage->txn_rollback;
 
-1;
index 08e09a1..572bc0a 100755 (executable)
@@ -389,4 +389,3 @@ subtest 'deletedbiblio_metadata' => sub {
     is( $moved, $biblionumber, 'Found in deletedbiblio_metadata' );
 };
 
-1;
index 2b92b2f..2537723 100644 (file)
@@ -279,4 +279,3 @@ t::lib::Mocks::mock_preference( 'item-level_itypes', 0 );
 
 $schema->storage->txn_rollback;
 
-1;
index f74327f..4e21c41 100644 (file)
@@ -131,4 +131,3 @@ is( $check_if_issued, 1, 'CheckIfIssuedToPatron returns true' );
 
 $dbh->rollback();
 
-1;
index 39cad00..505955f 100644 (file)
@@ -84,4 +84,3 @@ is( $check_valid_barcode, 0, 'CheckValidBarcode with an invalid barcode returns
 
 $dbh->rollback();
 
-1;
index 3d28e50..d47f38a 100644 (file)
@@ -82,4 +82,3 @@ is( scalar @$onsite_checkouts, 1, "There is 1 pending on-site checkout" );
 
 $schema->storage->txn_rollback;
 
-1;
index a3428eb..7fc7f14 100644 (file)
@@ -58,4 +58,3 @@ unlike ( $@, qr<Fatal error: the patron \(\d+\) .* AnonymousPatron>, );
 
 $schema->storage->txn_rollback;
 
-1;
index dc2c880..1fc8aa0 100644 (file)
@@ -65,4 +65,3 @@ is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, "Patron cannot check
 
 $schema->storage->txn_rollback;
 
-1;
index 4135d66..e6406b3 100644 (file)
@@ -330,4 +330,3 @@ subtest 'Handle ids duplication' => sub {
     is( Koha::Checkouts->find( $issue_id )->issue_id, $issue_id, 'The issues entry should not have been removed' );
 };
 
-1;
index 7d62474..15d0906 100644 (file)
@@ -141,4 +141,3 @@ subtest 'Test StoreLastBorrower' => sub {
 
 $schema->storage->txn_rollback;
 
-1;
index 48c2a60..3397e23 100644 (file)
@@ -161,4 +161,3 @@ is( exists $impossible->{TOO_MANY}, '', 'Specific case 2 - Switch is allowed' );
 
 $schema->storage->txn_rollback;
 
-1;
index 428c08b..7ce7e8e 100644 (file)
@@ -413,4 +413,3 @@ sub teardown {
     $dbh->do(q|DELETE FROM issuingrules|);
 }
 
-1;
index 57f306e..dbb7e0b 100644 (file)
@@ -120,4 +120,3 @@ sub calc_date_due {
 
 $schema->storage->txn_rollback;
 
-1;
index ab39a6d..ee0f83b 100755 (executable)
@@ -231,4 +231,3 @@ is( $patron->get_enrollable_clubs->count,
 is( $club->club_enrollments->count, 1, 'There is 1 enrollment for club' );
 
 $schema->storage->txn_rollback();
-1;
index 9325c72..5a75acd 100755 (executable)
@@ -149,4 +149,3 @@ sub TransformVersionToNum {
     $version =~ s/XXX$/999/;
     return $version;
 }
-1;
index d4faaa3..00d1b9f 100755 (executable)
@@ -190,4 +190,3 @@ ok( $needsconfirmation->{HIGHHOLDS}, "High holds checkout needs confirmation" );
 ok( !$needsconfirmation->{HIGHHOLDS}, "High holds checkout does not need confirmation" );
 
 $schema->storage->txn_rollback();
-1;
index b3ef6c1..ac10cbf 100644 (file)
@@ -213,4 +213,3 @@ subtest 'export without record_type' => sub {
 
 $schema->storage->txn_rollback;
 
-1;
index bd684b6..64759fa 100644 (file)
@@ -206,4 +206,3 @@ subtest 'Koha::Filter::MARC::ViewPolicy intranet tests' => sub {
     $schema->storage->txn_rollback();
 };
 
-1;
index 71ce265..6c51f54 100755 (executable)
@@ -172,4 +172,3 @@ subtest "delete() tests" => sub {
     $schema->storage->txn_rollback();
  };
 
-1;
index 360bfda..70c71d4 100755 (executable)
@@ -203,4 +203,3 @@ sub _add_exception {
 
 $schema->storage->txn_rollback;
 
-1;
index 88e8181..7677db0 100644 (file)
@@ -198,4 +198,3 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes
     $schema->storage->txn_rollback;
 };
 
-1;
index 29078ca..d1a9e82 100644 (file)
@@ -95,4 +95,3 @@ is( $get_item_level_hold_2->{biblionumber}, $to_biblio->{biblionumber},   'MoveI
 
 $schema->storage->txn_rollback;
 
-1;
index 20b3b11..57514d0 100644 (file)
@@ -167,4 +167,3 @@ is( $test_item->{itemnumber}, undef,
 
 $schema->storage->txn_rollback;
 
-1;
index b247d8b..85bf921 100755 (executable)
@@ -57,4 +57,3 @@ is( $subtitles[1], 'Another Test Record Subtitle', 'Got second subtitle correctl
 
 $schema->storage->txn_rollback();
 
-1;
index 59defcf..9f6a14a 100644 (file)
@@ -82,4 +82,3 @@ subtest 'subscriptions' => sub {
 
 $schema->storage->txn_rollback;
 
-1;
index 89b0126..c8ec4c5 100644 (file)
@@ -105,4 +105,3 @@ is( Koha::Checkouts->search->count, $nb_of_checkouts + 1, 'Delete should have de
 
 $schema->storage->txn_rollback;
 
-1;
index 941dd75..9947d3b 100644 (file)
@@ -56,4 +56,3 @@ is( Koha::Cities->search->count, $nb_of_cities + 1, 'Delete should have deleted
 
 $schema->storage->txn_rollback;
 
-1;
index 8b021b1..e5d02b2 100644 (file)
@@ -55,4 +55,3 @@ is( Koha::CsvProfiles->search->count, $nb_of_csv_profiles + 1, 'Delete should ha
 
 $schema->storage->txn_rollback;
 
-1;
index 8f250dd..ca70fb1 100755 (executable)
@@ -150,4 +150,3 @@ subtest 'EmbedItemsAvailability tests' => sub {
     $schema->storage->txn_rollback();
 };
 
-1;
index 2285be1..392cdec 100644 (file)
@@ -250,4 +250,3 @@ sub _row_match {
 
 $schema->storage->txn_rollback;
 
-1;
index 635c9a4..b49f780 100644 (file)
@@ -66,4 +66,3 @@ is( $retrieved_transfer_1->itemnumber, $new_transfer_1->itemnumber, 'Find a tran
 
 $schema->storage->txn_rollback;
 
-1;
index fd445b5..0864825 100644 (file)
@@ -123,4 +123,3 @@ is( Koha::Items->search->count, $nb_of_items + 1, 'Delete should have deleted th
 
 $schema->storage->txn_rollback;
 
-1;
index 8126b8c..483c7c8 100644 (file)
@@ -87,4 +87,3 @@ $retrieved_category_2->delete;
 is( Koha::LibraryCategories->search->count, $nb_of_categories + 2, 'Delete should have deleted the library category' );
 
 $schema->storage->txn_rollback;
-1;
index b61837a..b7ff454 100644 (file)
@@ -54,4 +54,3 @@ is( Koha::MarcSubfieldStructures->search->count, $nb_of_fields + 1, 'Delete shou
 
 $schema->storage->txn_rollback;
 
-1;
index bc5c5c9..e1b56f5 100644 (file)
@@ -56,4 +56,3 @@ is( Koha::News->search->count, $nb_of_news + 1, 'Delete should have deleted the
 
 $schema->storage->txn_rollback;
 
-1;
index 3f90f9f..dc9646f 100644 (file)
@@ -68,4 +68,3 @@ is( Koha::Notice::Templates->search->count,
 
 $schema->storage->txn_rollback;
 
-1;
index f5f9472..c05afc3 100644 (file)
@@ -214,4 +214,3 @@ subtest 'Exceptions' => sub {
 };
 
 $schema->storage->txn_rollback;
-1;
index d125dbe..06aca19 100644 (file)
@@ -336,4 +336,3 @@ subtest 'search() with branch limits tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-1;
index cbb02b9..044f317 100644 (file)
@@ -275,4 +275,3 @@ subtest 'type() tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-1;
index 574d458..6a0171f 100644 (file)
@@ -115,4 +115,3 @@ is( Koha::Patron::Categories->search->count, $nb_of_categories + 2, 'upperagelim
 
 $schema->storage->txn_rollback;
 
-1;
index ab0341b..86f705d 100644 (file)
@@ -51,4 +51,3 @@ is( Koha::Patron::Images->search->count, $nb_of_images, 'Delete should have dele
 
 $schema->storage->txn_rollback;
 
-1;
index fc69c0f..a64327d 100644 (file)
@@ -93,4 +93,3 @@ sub get_nb_of_logactions {
     return scalar( @{ C4::Log::GetLogs( undef, undef, undef, ['MEMBERS'] ) } );
 }
 
-1;
index af6df4c..53664f5 100755 (executable)
@@ -370,4 +370,3 @@ subtest 'pending_count() and pending() tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-1;
index 84c46ca..41f6e33 100644 (file)
@@ -913,4 +913,3 @@ is( Koha::Patrons->search->count, $nb_of_patrons + 1, 'Delete should have delete
 
 $schema->storage->txn_rollback;
 
-1;
index cc2c5cc..00229e0 100755 (executable)
@@ -57,4 +57,3 @@ is( Koha::Ratings->search( { biblionumber => $biblionumber } )->count, 0, 'Delet
 
 is( int(Koha::Ratings->search( { biblionumber => $biblionumber } )->get_avg_rating), 0, 'get_avg_rating should return 0 if no rating exist' );
 
-1;
index da164f7..91f86fe 100644 (file)
@@ -70,4 +70,3 @@ is( Koha::Reviews->search->count, $nb_of_reviews + 2, 'Delete should have delete
 
 $schema->storage->txn_rollback;
 
-1;
index 407363b..a469d77 100644 (file)
@@ -72,4 +72,3 @@ is( Koha::SMS::Providers->search->count,
 
 $schema->storage->txn_rollback;
 
-1;
index 732ac68..2e7146f 100644 (file)
@@ -78,4 +78,3 @@ is( Koha::Suggestions->search->count, $nb_of_suggestions + 1, 'Delete should hav
 
 $schema->storage->txn_rollback;
 
-1;
index ef95a03..05785e7 100644 (file)
@@ -151,5 +151,3 @@ subtest 'get_fixer_rules() tests' => sub {
     $schema->storage->txn_rollback;
 
 };
-
-1;
index e08d6c0..9a525bf 100644 (file)
@@ -122,5 +122,3 @@ subtest '_convert_marc_to_json() tests' => sub {
 
     $schema->storage->txn_rollback;
 };
-
-1;
index 6a51126..18fbab0 100755 (executable)
@@ -87,4 +87,3 @@ is(scalar @{$mf_b_221->GetFilesInfo()}, 0, "GetFilesInfo() result count after De
 
 $dbh->rollback;
 
-1;
index f83bd8d..5c37200 100644 (file)
@@ -103,4 +103,3 @@ subtest 'build_query tests' => sub {
         'holdingbranch not added to facets if DisplayLibraryFacets=home' );
 };
 
-1;
index 87db848..54be026 100644 (file)
@@ -109,4 +109,3 @@ is($updated_layout->get_text_wrap_cols(label_width => 180, left_text_margin => 1
 my $del_results = $updated_layout->delete();
 ok( ! defined($del_results) , "Layout->delete() success");
 
-1;
index e918ca4..fec46e5 100644 (file)
@@ -95,4 +95,3 @@ is_deeply($updated_profile, $saved_profile, "Updated layout object verify succes
 my $del_results = $updated_profile->delete();
 ok($del_results ne -1, "Profile->delete() success");
 
-1;
index 0eb6871..8cf4cd6 100644 (file)
@@ -135,4 +135,3 @@ foreach my $key (keys %{$expect_conv}) {
 my $del_results = $updated_template->delete();
 ok($del_results ne -1, "Template->delete() success");
 
-1;
index e6d15ee..6433201 100644 (file)
@@ -112,4 +112,3 @@ is( $issues->[0]->{itemnumber}, $itemnumber3, '' );
 
 $schema->storage->txn_begin;
 
-1;
index 438fc3c..4ef7e27 100644 (file)
@@ -404,4 +404,3 @@ subtest 'bad calls' => sub {
 
 $schema->storage->txn_rollback;
 
-1;
index 893e025..f11893f 100755 (executable)
@@ -194,4 +194,3 @@ ok( scalar @$letters == 2, "[SendPasswordRecoveryEmail] UPDATE == ON sends a new
 
 $schema->storage->txn_rollback();
 
-1;
index d5e3e2d..ddc6835 100644 (file)
@@ -128,4 +128,3 @@ is( ref(Koha::Patron::Discharge::request({ borrowernumber => $patron->{borrowern
 
 $schema->storage->txn_rollback;
 
-1;
index 0950964..b5024bc 100755 (executable)
@@ -36,4 +36,3 @@ is(
 
 $schema->storage->txn_rollback;
 
-1;
index c8898b9..090ca63 100644 (file)
@@ -85,4 +85,3 @@ isa_ok(Koha::Patrons->search_housebound_deliverers->next, "Koha::Patron");
 
 $schema->storage->txn_rollback;
 
-1;
index e6f8245..eee3f00 100644 (file)
@@ -86,4 +86,3 @@ isa_ok( $result->chooser, "Koha::Patron");
 
 $schema->storage->txn_rollback;
 
-1;
index e7f4f87..63fbc23 100755 (executable)
@@ -102,4 +102,3 @@ ok( !@lists, 'DelPatronList works' );
 
 $schema->storage->txn_rollback;
 
-1;
index 40f770d..a1c7ad9 100755 (executable)
@@ -105,4 +105,3 @@ foreach my $b ( $patrons->as_list() ) {
 
 $schema->storage->txn_rollback();
 
-1;
index a8d7bdc..58120d7 100644 (file)
@@ -68,4 +68,3 @@ sub get_default_search_class {
     return $default_search_class;
 }
 
-1;
index 2a8a759..84a373a 100755 (executable)
@@ -280,4 +280,3 @@ subtest 'Koha::RefundLostItemFeeRules::should_refund() tests' => sub {
     $schema->storage->txn_rollback;
 };
 
-1;
index 31e45bb..97d870a 100755 (executable)
@@ -222,4 +222,3 @@ sub addreserve {
 
 $schema->storage->txn_rollback;
 
-1;
index 293ab6a..70f2600 100755 (executable)
@@ -291,4 +291,3 @@ is( $can, 'tooManyHoldsForThisRecord', 'Third hold exceeds limit of holds per re
 
 $schema->storage->txn_rollback;
 
-1;
index 588dde1..4adecf9 100755 (executable)
@@ -75,4 +75,3 @@ subtest 'Get_timeout' => sub {
     is( C4::SIP::SIPServer::get_timeout( $server, { transport => 1 } ), 30, "Fallback again" );
 };
 
-1;
index c8cbc48..dee0ed2 100644 (file)
@@ -988,4 +988,3 @@ subtest 'UNIMARC + DOM' => sub {
 # Make sure that following tests are not using our config settings
 Koha::Caches->get_instance('config')->flush_all;
 
-1;
index a214a97..1a90c51 100644 (file)
@@ -93,4 +93,3 @@ is ( $history->histenddate(), undef, 'subscription history not empty after renew
 
 $schema->storage->txn_rollback;
 
-1;
index 5ae4a2f..6ea75f8 100644 (file)
@@ -57,4 +57,3 @@ is( Koha::Template::Plugin::Categories->GetName(
 
 $schema->storage->txn_rollback;
 
-1;
index 2df099e..760b9f0 100755 (executable)
@@ -105,4 +105,3 @@ subtest 'Testing gettemplate' => sub {
     is( $template ? $template->output: '', '', 'Check output' );
 };
 
-1;
index 949d959..1d162cf 100644 (file)
@@ -475,5 +475,3 @@ sub set_logged_in_user {
         '',                      ''
     );
 }
-
-1;
index e6e13c6..bf2a8f0 100644 (file)
@@ -376,4 +376,3 @@ sub create_user_and_session {
     return ( $user->{borrowernumber}, $session->id );
 }
 
-1;
index 25f574a..41de507 100644 (file)
@@ -61,4 +61,3 @@ for my $modules ( @modules ) {
 
 done_testing();
 
-1;
index 265865c..bcb65d1 100644 (file)
@@ -188,4 +188,3 @@ if ($id_to_del2) {
     ok($id_to_del2 ne undef, "error, link to delete not working");
 }
 
-1;
index 30d9886..8704acb 100644 (file)
@@ -210,4 +210,3 @@ $agent->get("$intranet/cgi-bin/koha/tools/batch_records_ajax.pl?import_batch_id=
 $jsonresponse = decode_json $agent->content;
 is( $jsonresponse->{ aaData }[0]->{ status }, 'reverted', 'record marked as reverted' );
 
-1;
index b71f7b6..d22ba0a 100644 (file)
@@ -64,4 +64,3 @@ my $history_page          = Encode::encode('UTF-8', $agent->text());
 like( $history_page, qr/$encoded_latin_name/, "Latin characters with umlauts show correctly on the history page." );
 like( $history_page, qr/$encoded_cyrillic_name/, "Cyrillic characters with umlauts show correctly on the history page." );
 
-1;