Bug 14642: Make sure the log will be written only if the hold has been deleted

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

diff --git a/Koha/Hold.pm b/Koha/Hold.pm
index 3cc8440..ba75a52 100644 (file)
--- a/Koha/Hold.pm
+++ b/Koha/Hold.pm
@@ -99,10 +99,12 @@ $hold->delete();
 sub delete {
     my ( $self ) = @_;
 
+    my $deleted = $self->SUPER::delete($self);
+
     logaction( 'HOLDS', 'DELETE', $self->reserve_id, Dumper($self->unblessed) )
         if C4::Context->preference('HoldsLog');
 
-    return $self->SUPER::delete($self);
+    return $deleted;
 }
 
 =head3 waiting_expires_on