Bug 21792: Switch two-column templates to Bootstrap grid: Serials part 3
authorOwen Leonard <oleonard@myacpl.org>
Thu, 8 Nov 2018 17:10:00 +0000 (17:10 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 25 Jan 2019 20:32:48 +0000 (20:32 +0000)
This patch modifies several serials templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and go to Serials.

 - Add or edit a new subscription. The "create an item..." and "do not
   create an item..." labels should look correct.
 - Search for subscriptions
   - Select two or more subscriptions to batch edit.
     - The subscription batch edit page should look correct and adjust
       well to various browser widths.
   - View a subscription and click the "Renew" button. The subscription
     renewal pop-up window should look correct.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt

index beb8d59..7fb822e 100644 (file)
@@ -7,11 +7,8 @@
 [% INCLUDE 'doc-head-open.inc' %]
 <title>Koha &rsaquo; Serials &rsaquo; [% IF ( modify ) %][% bibliotitle | html %] &rsaquo; Modify subscription[% ELSE %]New subscription[% END %]</title>
 [% INCLUDE 'doc-head-close.inc' %]
-<style type="text/css">
+<style>
 fieldset.rows li.radio { width: 100%; } /* override staff-global.css */
-.yui-u li p label.widelabel {
-width: 300px;  /* not enough for IE7 apparently */
-}
 </style>
 </head>
 
@@ -519,7 +516,7 @@ width: 300px;  /* not enough for IE7 apparently */
 [% MACRO jsinclude BLOCK %]
     [% INCLUDE 'calendar.inc' %]
     [% INCLUDE 'datatables.inc' %]
-    <script type="text/javascript">
+    <script>
         var subscriptionid = "[% subscriptionid | html %]";
         var irregularity = "[% irregularity | html %]";
         var more_than_one_serial = "[% more_than_one_serial | html %]";
index 5876983..327e08f 100644 (file)
         Batch edit
     </div>
 
-    <div id="doc3" class="yui-t2">
-        <div id="bd">
-            <div id="yui-main">
-                <div class="yui-b">
+<div class="main container-fluid">
+    <div class="row">
+        <div class="col-sm-10 col-sm-push-2">
+            <main>
+
                     <h1>Subscription batch edit</h1>
 
                     <div>
                             <a class="cancel" href="[% referrer | url %]">Cancel</a>
                         </fieldset>
                     </form>
-                </div>
-            </div>
-            <div class="yui-b">
+
+            </main>
+        </div> <!-- /.col-sm-10.col-sm-push-2 -->
+
+        <div class="col-sm-2 col-sm-pull-10">
+            <aside>
                 [% INCLUDE 'serials-menu.inc' %]
-            </div>
-        </div>
+            </aside>
+        </div> <!-- /.col-sm-2.col-sm-pull-10 -->
+    </div> <!-- /.row -->
+
 
     [% INCLUDE 'intranet-bottom.inc' %]
index fcfbd26..9826464 100644 (file)
@@ -24,7 +24,7 @@
         <a class="btn btn-default btn-default close" href="#">Close</a>
     </div>
 [% ELSE %]
-      <div id="bd">
+
 <form name="f" action="/cgi-bin/koha/serials/subscription-renew.pl" method="post">
                <input type="hidden" name="op" value="renew" />
                <input type="hidden" name="subscriptionid" value="[% subscription.subscriptionid | html %]" />