Fix some compile time errors reported in test suite

redeclaration of itemnumber in RotatingCollections
A couple of errors caused by retaining commas in qw()

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

diff --git a/C4/Creators.pm b/C4/Creators.pm
index c9538e2..47900b5 100644 (file)
--- a/C4/Creators.pm
+++ b/C4/Creators.pm
@@ -2,7 +2,7 @@ package C4::Creators;
 
 BEGIN {
     use version; our $VERSION = qv('1.0.0_1');
-    use vars qw(@EXPORT, @ISA);
+    use vars qw(@EXPORT @ISA);
     @ISA = qw(Exporter);
     our @EXPORT = qw(get_all_templates
                      get_all_layouts

diff --git a/C4/Patroncards.pm b/C4/Patroncards.pm
index cc20c2c..e833193 100644 (file)
--- a/C4/Patroncards.pm
+++ b/C4/Patroncards.pm
@@ -2,7 +2,7 @@ package C4::Patroncards;
 
 BEGIN {
     use version; our $VERSION = qv('1.0.0_1');
-    use vars qw(@EXPORT, @ISA);
+    use vars qw(@EXPORT @ISA);
     @ISA = qw(Exporter);
     our @EXPORT = qw(unpack_UTF8
                      text_alignment

diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm
index c880fe8..b576868 100644 (file)
--- a/C4/RotatingCollections.pm
+++ b/C4/RotatingCollections.pm
@@ -504,7 +504,7 @@ sub isItemInAnyCollection {
       
   my $row = $sth->fetchrow_hashref;
         
-  my $itemnumber = $$row{'itemnumber'};
+  $itemnumber = $row->{itemnumber};
   $sth->finish;
             
   if ( $itemnumber ) {